Skip to content

Commit 9de0876

Browse files
committed
refactor: rename parse method, set failed on main flow
1 parent c8b3680 commit 9de0876

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

index.js

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,16 @@ function run() {
88
const minCoverageInput = core.getInput('min_coverage');
99
const excluded = core.getInput('exclude');
1010
const excludedFiles = excluded.split(' ');
11-
const minCoverage = parseMinCoverage(minCoverageInput);
11+
const minCoverage = tryParseMinCoverage(minCoverageInput);
1212

13-
if (minCoverage === null || !canParse(lcovPath)) {
13+
if (minCoverage === null) {
14+
core.setFailed(
15+
'❌ Failed to parse min_coverage. Make sure to enter a valid number between 0 and 100.',
16+
);
17+
return;
18+
}
19+
20+
if (!canParse(lcovPath)) {
1421
return;
1522
}
1623

@@ -108,17 +115,14 @@ you have no test files or your tests are not generating any coverage data.
108115
return true;
109116
}
110117

111-
function parseMinCoverage(input) {
118+
function tryParseMinCoverage(input) {
112119
if (input === '') {
113120
return 100;
114121
}
115122

116123
const minCoverage = Number(input);
117124

118125
if (isNaN(minCoverage) || minCoverage < 0 || minCoverage > 100) {
119-
core.setFailed(
120-
'❌ Failed to parse min_coverage. Make sure to enter a valid number between 0 and 100.',
121-
);
122126
return null;
123127
}
124128

0 commit comments

Comments
 (0)