Skip to content

Adding in script for Oracle RBAC work #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Adding in script for Oracle RBAC work #91

merged 1 commit into from
Mar 21, 2024

Conversation

alexoelke
Copy link
Collaborator

No description provided.

rkennedy
rkennedy previously approved these changes Jan 3, 2024
Copy link
Collaborator

@rkennedy rkennedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. There are some things that I think could be better, but I think it's on par with the rest of what we've published.

# Cred? if doesn't already exist
# register creds

## The script can be run with Python 3.5 or higher version.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, Python 3.5 reached EOL over three years ago.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'm not sure if we want to update the statement at the top to what it was developed with? It'll probably run with 3.5 but yeah I get its outdated.

@rkennedy rkennedy merged commit 29749ab into master Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants