Withdraw a raised delete once its file is in use again - #1938
Merged
Merged
Conversation
A delete is raised for a verified file no target produced, and waits in the tray or the viewer for someone to accept it. Nothing withdrew it when the file came back into use - a target that came back, or a snapshot that moved inline and then back out when the global switch was turned off - so accepting it removed a file a passing test depends on, and the next run failed for a snapshot that had been fine. A verification now withdraws, through DiffRunner.SettleDelete, the pending delete of every verified file it compared against, whether the comparison matched or not: a file that no longer matches is still the target of a pending move. Withdrawing for every verified file would cost a round trip to the queue owner per file, for every codebase. So the run that raises a delete records the file under the intermediate directory, before raising it, and only a recorded file is withdrawn. With nothing recorded that costs one directory check per process. A record whose file has gone is dropped when the records are read: accepting the delete removed it, and a tray drops a delete whose file is missing. Both answer to DiffRunner.Disabled, as raising always has, and a run that cannot reach the owner leaves the records for one that can. Per configuration and target framework, like the received maps: a delete one framework's run raised is withdrawn by that framework's next run that uses the file. SettleDelete arrived in DiffEngine 20.5.0, which is already referenced here.
This was referenced Sep 24, 2026
Closed
This was referenced Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A delete is raised for a verified file no target produced, and waits in the tray or the viewer for someone to accept it. Nothing withdrew it when the file came back into use - a target that came back, or a snapshot that moved inline and then back out when the global switch was turned off - so accepting it removed a file a passing test depends on, and the next run failed for a snapshot that had been fine.
A verification now withdraws, through
DiffRunner.SettleDelete, the pending delete of every verified file it compared against, whether the comparison matched or not: a file that no longer matches is still the target of a pending move.Withdrawing for every verified file would cost a round trip to the queue owner per file, for every codebase. So the run that raises a delete records the file under the intermediate directory, before raising it, and only a recorded file is withdrawn. With nothing recorded that costs one directory check per process. A record whose file has gone is dropped when the records are read: accepting the delete removed it, and a tray drops a delete whose file is missing.
Both answer to
DiffRunner.Disabled, as raising always has, and a run that cannot reach the owner leaves the records for one that can.Per configuration and target framework, like the received maps: a delete one framework's run raised is withdrawn by that framework's next run that uses the file.
SettleDeletearrived in DiffEngine 20.5.0, which is already referenced here.Tests
RaisedDeleteTestscovers a delete withdrawn once its file matches again, and once it no longer matches; records left for a later run where DiffEngine is off; nothing recorded while it is off; a record whose file has gone; and nothing sent when nothing was raised. Each was checked against the unfixed code.