Added list of matching groups #28 #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -746,6 +748,21 @@ public String getText(final String toTest, final int group) { | |||
| return result.toString(); | |||
| } | |||
|
|
|||
| /** | |||
| * Extract exact group from string and add it to list | |||
| * | |||
There was a problem hiding this comment.
Can you add example to javadoc of how it works?
There was a problem hiding this comment.
Sure, but i can do this a little bit later.
There was a problem hiding this comment.
Can be in separate pr so, i'll merge and make release
lanwen
added a commit
that referenced
this pull request
Jan 6, 2016
Added list of matching groups #28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @lanwen , i have added minor improvement #28
Thanks!