[ObjC] Use NamedTypeReference to refer to id / SEL / BOOL #7077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdash
force-pushed
the
objc-ntr
branch
2 times, most recently
from
a8093fc to
b226f2a
Compare
bdash
added a commit
that referenced
this pull request
Jul 11, 2025
Rather than introducing duplicate definitions of these types, use a NamedTypeReference that will be resolved to the type from the libobjc type library when it is loaded. This prevents these types from showing up as id_1 / SEL_1 in some places rather than as their expected names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than introducing duplicate definitions of these types, use a
NamedTypeReferencethat will be resolved to the type from the libobjc type library when it is loaded.This prevents these types from showing up as
id_1/SEL_1in some places rather than as their expected names.Fixes #7061.
I tried about 5 different ways of referencing a type by name and this is the only one that seemed to work correctly:
I'm not really clear why that works but
Type::NamedType(m_data, name)doesn't.