Skip to content

Commit 63e4f9e

Browse files
committed
[ObjC] Silence some more unnecessary logging
1 parent 16595bf commit 63e4f9e

File tree

1 file changed

+3
-12
lines changed

1 file changed

+3
-12
lines changed

plugins/workflow_objc/src/activities/super_init.rs

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ use binaryninja::{
44
function::Function,
55
medium_level_il::{
66
operation::{
7-
Constant, LiftedCallSsa, LiftedLoadSsa, LiftedSetVarSsa, LiftedSetVarSsaField,
8-
LiftedVarPhi, Var, VarSsa,
7+
Constant, LiftedCallSsa, LiftedLoadSsa, LiftedSetVarSsa, LiftedSetVarSsaField, Var,
8+
VarSsa,
99
},
1010
MediumLevelILFunction, MediumLevelILLiftedInstruction, MediumLevelILLiftedInstructionKind,
1111
},
@@ -169,18 +169,9 @@ fn return_type_for_super_init(call: &Call, view: &BinaryView) -> Option<Ref<Type
169169

170170
let src = match super_param_def.lift().kind {
171171
MediumLevelILLiftedInstructionKind::SetVarSsa(LiftedSetVarSsa { src, .. }) => src,
172-
MediumLevelILLiftedInstructionKind::VarPhi(LiftedVarPhi { .. }) => {
172+
_ => {
173173
// The Swift compiler generates code that conditionally assigns to the receiver field of `objc_super`.
174-
// TODO: Recognize that pattern and handle it.
175174
log::debug!(
176-
" found phi node for definition of `objc_super` variable at {:#0x} {:?}",
177-
super_param_def.address,
178-
super_param_def
179-
);
180-
return None;
181-
}
182-
_ => {
183-
log::error!(
184175
"Unexpected variable definition kind at {:#0x} {:#x?}",
185176
super_param_def.address,
186177
super_param_def

0 commit comments

Comments
 (0)