Skip to content

Conversation

@AstardGrimoire
Copy link

Hi!
I've noticed that your mod's russian translation file was slightly outdated. So i decided to update and forked your mods repository to be able to do a pull request when i finish.
Previous translations were mostly correct, but there were some grammar errors and typos, which i fixed in commits below. Also i noticed that lang file contained strings for stuff that is no longer in the mod, such as pink blossom trees, soul compass e.t.c. So i deleted those and now amount of strings matches en_us. Also some items were renamed, like ancient tree now being ashen tree. Along with that, i increased general quality of translations a bit.
Are you going to go over my translations? To make sure that they are valid or I didn't forget anything? Are there, like, any conditions that can affect acceptance?
If my translations are accepted, I would really appreciate it. (I did read contribution guidelines, but wrong translations are not really an issue? I replaced lang file and it works as intended, so nothing to worry about)

Copy link
Contributor

@kkylern kkylern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Нужны некоторые изменения. Пожалуйста, прочитай мои комментарии через View reviewed changes.
Впервые кидаю ревью, но теперь вижу, что лучше было сделать пулл реквест или совместную работу в форк-репозитории. Связаться со мной можно через дискорд: _r4v3n

Заметил, что есть пропущенные опечатки.
Если редактируешь файл локализации через Notepad++, то можешь скачать аддон DSpellCheck и закинуть к нему словарь отсюда:
https://extensions.libreoffice.org/en/extensions/show/russian-spellcheck-dictionary.-based-on-works-of-aot-group
Если через VSCode, то там есть расширение Hunspell (я не использовал, но предполагаю, что можно). Туда закинуть этот же словарь.

AstardGrimoire and others added 2 commits August 16, 2025 11:32
Co-authored-by: kkylern <144598121+kkylern@users.noreply.github.com>
@AstardGrimoire
Copy link
Author

AstardGrimoire commented Aug 16, 2025

Я добавил твои предложения в файл перевода, и внёс ещё несколько других изменений.
Если что, я редактирую файлы перевода прямо в гитхабе через эдит.

Co-authored-by: kkylern <144598121+kkylern@users.noreply.github.com>
Copy link
Contributor

@kkylern kkylern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All done, PR can be accepted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants