make buttons non flammable. fix #4881 #5069
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
not sure about this one. Minecraft doesnt have non-nether buttons in that tag |
Collaborator
|
We should probably fix this Zeta-side. The reason Zeta uses the sound-type (of all things) is because 1.20 deleted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ancient, azalea, and blossom buttons to non_flammable_wood block tags.
I'm not sure why Zeta uses the SoundType instead of the Material to make things flammable, but that's the reason why Quark's buttons were flammable while vanilla buttons (and torches, levers, repeaters, etc. which all have wood SoundType but decoration Material) are not.
#Modtoberfest2024