Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some configuration options #26

Open
HuiiBuh opened this issue Apr 17, 2021 · 4 comments
Open

Add some configuration options #26

HuiiBuh opened this issue Apr 17, 2021 · 4 comments

Comments

@HuiiBuh
Copy link

HuiiBuh commented Apr 17, 2021

First if all. I love your work. I was just amazed how easy the extension was created.

The only thing i am missing is some configuration options regarding the location of the files.
I would suggest to add an. env file in which you can specify the location of the options/popup/... location.

I had a quick look at thr source code and it looks like you just have to modify the packages/react-scripts/config/paths.js. I would like to create a PR in which some configuration options for the location het added.

@Dimi-Dun-Morogh
Copy link

yeah I'd love to have an option to exclude contentScript, options folder or w/e is unnecessary for specific extenstion

@VasilyShelkov
Copy link
Owner

Hi, thanks for your comments. I think they're great discussions to have and decide on.

The only thing i am missing is some configuration options regarding the location of the files.
I would suggest to add an. env file in which you can specify the location of the options/popup/... location.

What's the main reason/use cases why you think it's important to have this configuration? I'm looking to understand if there's something which justifies more configuration for something that isn't personal preference.

The reason I ask is because generally both CRA + this repo want to "standardise" the simple cases. If one wants to build with a different structure, there's no problem with ejecting, however, by having the same structure, it keeps all projects created with create-react-extension the same and predictable within the community. Same way that all create-react-app projects are within the src folder.

@HuiiBuh
Copy link
Author

HuiiBuh commented Apr 27, 2021

The reason I would like to modify the paths is that there are so many entry points in create-react-extension in comparison to create-react-app.
And if I would like to structure these different entry points differently than the default structure I would have to eject which I really don't want to do for such a small change.
I would certainly keep a default configuration which most people could use without even knowing that there are more configuration options available and a more advanced config for people who would like to customize their project a bit more.
This would be possible with an env file and a concept like this is already used by cra if you would like to disable the browser opening on every app start.

@jonathangaldino
Copy link

I'm glad that I found this issue. I am missing this config file, for the same reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants