-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some configuration options #26
Comments
yeah I'd love to have an option to exclude contentScript, options folder or w/e is unnecessary for specific extenstion |
Hi, thanks for your comments. I think they're great discussions to have and decide on.
What's the main reason/use cases why you think it's important to have this configuration? I'm looking to understand if there's something which justifies more configuration for something that isn't personal preference. The reason I ask is because generally both CRA + this repo want to "standardise" the simple cases. If one wants to build with a different structure, there's no problem with ejecting, however, by having the same structure, it keeps all projects created with |
The reason I would like to modify the paths is that there are so many entry points in create-react-extension in comparison to create-react-app. |
I'm glad that I found this issue. I am missing this config file, for the same reasons. |
First if all. I love your work. I was just amazed how easy the extension was created.
The only thing i am missing is some configuration options regarding the location of the files.
I would suggest to add an. env file in which you can specify the location of the options/popup/... location.
I had a quick look at thr source code and it looks like you just have to modify the packages/react-scripts/config/paths.js. I would like to create a PR in which some configuration options for the location het added.
The text was updated successfully, but these errors were encountered: