Bring back support for ruby 1.9

Author: Vasfed

.github/workflows/test.yml

@@ -8,15 +8,16 @@ jobs:
       matrix:
         # lockfiles are not commited, so autodetection will not work, need to specify bundler version
         include:
-          - ruby-version: 2.3.8
+          - ruby-version: 1.9.3
             rails-version: 3
-            bundler-version: 1.17.3
+            bundler-version: "1.17.3"
+
           - ruby-version: 2.3.8
             rails-version: 40
-            bundler-version: 1.17.3
+            bundler-version: "1.17.3"
           - ruby-version: 2.3.8
             rails-version: 42
-            bundler-version: 1.17.3
+            bundler-version: "1.17.3"
 
           - ruby-version: 2.3.8
             rails-version: 50_rspec
@@ -36,8 +37,14 @@ jobs:
 
     steps:
       - uses: actions/checkout@master
+      - name: Disable broken ssl for legacy ruby
+        run: |
+          echo :ssl_verify_mode: 0 >> ~/.gemrc
+          echo gem: --no-ri --no-rdoc >> ~/.gemrc
+          echo "RUBYGEMS_HOST=http://rubygems.org" >> $GITHUB_ENV
+        if: matrix.ruby-version == '1.9.3'
       - name: Install ruby
-        uses: ruby/setup-ruby@v1
+        uses: ruby/setup-ruby@master
         with:
           ruby-version: ${{ matrix.ruby-version }}
           bundler-cache: true

Appraisals

@@ -4,9 +4,19 @@
 
 if RUBY_VERSION <= '2.4'
   # to get a working ruby 2.3: `docker run --rm -it --volume $PWD:/app ruby:2.3-stretch bash`
+  # to get a working ruby 1.9: `docker run --rm -it --volume $PWD:/app ruby:1.9.3-wheezy bash`
   appraise 'rails-3' do
     gem 'rails', '~>3.2.22'
     gem 'test-unit'
+    # helping old bundler with correct versions with support for ruby 1.9:
+    if RUBY_VERSION < '2'
+      gem 'rake', '~> 11.3'
+      gem 'concurrent-ruby', '1.1.9'
+      gem 'rack-cache', '1.7.0'
+      gem 'thor', '0.20.3'
+      gem 'appraisal', '2.2.0'
+      gem 'minitest', '5.11.3'
+    end
   end
 
   appraise 'rails-40' do

CHANGELOG.md

@@ -2,7 +2,7 @@
 
 ## Unreleased
 
--
+- Bring back support for ruby 1.9
 
 ## 0.7.0 - April 24, 2022
 - Support for Rails 7 (added tests, main code was already working)

Rakefile

@@ -20,7 +20,7 @@ Rake::TestTask.new(:dummytest_controller) { |t| t.pattern = 'spec/fixtures/dummy
 
 task default: :spec
 
-$LOAD_PATH.push File.expand_path('lib', __dir__)
+$LOAD_PATH.push File.expand_path('../lib', __FILE__)
 require 'routes_coverage/version'
 
 namespace :assets do

gemfiles/rails_3.gemfile

@@ -4,5 +4,11 @@ source "https://rubygems.org"
 
 gem "rails", "~>3.2.22"
 gem "test-unit"
+gem 'rake', '~> 11.3'
+gem 'concurrent-ruby', '1.1.9'
+gem 'rack-cache', '1.7.0'
+gem 'thor', '0.20.3'
+gem 'appraisal', '2.2.0'
+gem 'minitest', '5.11.3'
 
 gemspec path: "../"

lib/routes_coverage.rb

@@ -19,10 +19,14 @@ def process(action, *args)
   end
 
   module ActionControllerTestCaseKvargs
-    def process(action, **kvargs)
-      return super unless RoutesCoverage.settings.include_from_controller_tests
+    if RUBY_VERSION >= '2'
+      class_eval <<-RUBY, __FILE__, __LINE__+1
+        def process(action, **kvargs)
+          return super unless RoutesCoverage.settings.include_from_controller_tests
 
-      super.tap { RoutesCoverage._touch_request(@request) }
+          super.tap { RoutesCoverage._touch_request(@request) }
+        end
+      RUBY
     end
   end
 
@@ -154,7 +158,7 @@ def self._collect_all_routes
   end
 
   def self._collect_route_groups(all_routes)
-    settings.groups.map do |group_name, matcher|
+    Hash[settings.groups.map do |group_name, matcher|
       group_routes = all_routes.select do |route|
         if matcher.respond_to?(:call)
           matcher.call(route)
@@ -164,9 +168,9 @@ def self._collect_route_groups(all_routes)
             when :path
               route.path.spec.to_s =~ value
             when :action
-              route.requirements[:action]&.match(value)
+              route.requirements[:action] && route.requirements[:action].match(value)
             when :controller
-              route.requirements[:controller]&.match(value)
+              route.requirements[:controller] && route.requirements[:controller].match(value)
             when :constraints
               value.all? do |constraint_name, constraint_value|
                 if constraint_value.present?
@@ -183,7 +187,7 @@ def self._collect_route_groups(all_routes)
       end
 
       [group_name, Result.new(group_routes, route_hit_count.slice(*group_routes), settings)]
-    end.to_h
+    end]
   end
 
   # NB: router changes env/request during recognition

lib/routes_coverage/auditor.rb

@@ -55,7 +55,7 @@ def existing_actions_usage_hash
           controller_name = controller.name.sub(/Controller$/, "").underscore
           controller.action_methods.map { |action| "#{controller_name}##{action}" }
         end
-        controller_actions.flatten.map { |action| [action, 0] }.to_h
+        Hash[controller_actions.flatten.map { |action| [action, 0] }]
       end
     end
 
@@ -78,8 +78,9 @@ def perform
           existing_actions_usage_hash[action] += 1
         else
           # there may be inheritance or implicit renders
-          controller_instance = controller_class_by_name(route.requirements[:controller])&.new
-          unless controller_instance&.available_action?(route.requirements[:action])
+          controller_class = controller_class_by_name(route.requirements[:controller])
+          controller_instance = controller_class && controller_class.new
+          unless controller_instance && controller_instance.available_action?(route.requirements[:action])
             if controller_instance.respond_to?(route.requirements[:action])
               logger.warn "No action, but responds: #{action}"
             end
@@ -101,14 +102,15 @@ def unused_actions
       @unused_actions ||= begin
         # methods with special suffixes are obviously not actions, reduce noise:
         unused_actions_from_hash = existing_actions_usage_hash.reject do |action, count|
-          count.positive? || action.end_with?('?') || action.end_with?('!') || action.end_with?('=')
+          count > 0 || action.end_with?('?') || action.end_with?('!') || action.end_with?('=')
         end
 
         unused_actions_from_hash.keys.map do |action|
           controller_name, action_name = action.split('#', 2)
-          controller = controller_class_by_name(controller_name)&.new
-          method = controller.method(action_name.to_sym)
-          if method&.source_location && method.source_location.first.start_with?(root)
+          controller_class = controller_class_by_name(controller_name)
+          controller = controller_class && controller_class.new
+          method = controller && controller.method(action_name.to_sym)
+          if method && method.source_location && method.source_location.first.start_with?(root)
             "#{method.source_location.first.sub(root, '')}:#{method.source_location.second} - #{action}"
           else
             action

lib/routes_coverage/formatters/full_text.rb

@@ -6,13 +6,18 @@ class FullText < SummaryText
       class RouteFormatter
         attr_reader :buffer
 
-        def initialize(result = nil, _settings = nil, output_hits: false)
+        def initialize(result = nil, _settings = nil)
           @buffer = []
           @result = result
-          @output_hits = output_hits
+          @output_hits = false
           @output_prefix = false
         end
 
+        def with_hits
+          @output_hits = true
+          self
+        end
+
         def result
           @buffer.join("\n")
         end
@@ -63,7 +68,7 @@ def draw_header(routes)
         end
 
         def widths(routes)
-          %i[name verb path reqs].map do |key|
+          [:name, :verb, :path, :reqs].map do |key|
             routes.map { |r| r[key].length }.max.to_i
           end
         end
@@ -94,11 +99,9 @@ def hit_routes_details
         hit_routes = collect_routes(result.hit_routes)
         pending_routes = collect_routes(result.pending_routes)
 
-        <<~TXT
-          #{routes_section(RouteFormatter.new(result, settings, output_hits: true), 'Covered routes:', hit_routes)}
-
-          #{routes_section(RouteFormatter.new(result, settings), 'Pending routes:', pending_routes)}
-        TXT
+        "#{routes_section(RouteFormatter.new(result, settings).with_hits, 'Covered routes:', hit_routes)}\n"\
+        "\n"\
+        "#{routes_section(RouteFormatter.new(result, settings), 'Pending routes:', pending_routes)}"
       end
 
       def format

lib/routes_coverage/formatters/html.rb

@@ -55,7 +55,7 @@ def project_name
       end
 
       def asset_content(name)
-        File.read(File.expand_path("../../../compiled_assets/#{name}", __dir__))
+        File.read(File.expand_path("../../../../compiled_assets/#{name}", __FILE__))
       end
 
       def style_asset_link
@@ -87,7 +87,7 @@ def strength_css_class(covered_strength)
       end
 
       def hits_css_class(hits)
-        hits.positive? ? 'cov' : 'uncov'
+        hits > 0 ? 'cov' : 'uncov'
       end
 
       def timeago(time)

lib/routes_coverage/formatters/summary_text.rb

@@ -6,7 +6,7 @@ class SummaryText < Base
       def hits_count(result)
         "#{result.hit_routes_count} of #{result.expected_routes_count}"\
           "#{"(#{result.total_count} total)" if result.expected_routes_count != result.total_count}"\
-          " routes hit#{" at #{result.avg_hits} hits average" if result.hit_routes_count.positive?}"
+          " routes hit#{" at #{result.avg_hits} hits average" if result.hit_routes_count > 0}"
       end
 
       def status