Skip to content

Commit 2655b3d

Browse files
committed
Update old gemfiles
1 parent fe5afb6 commit 2655b3d

File tree

7 files changed

+6
-13
lines changed

7 files changed

+6
-13
lines changed

.github/workflows/test.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ jobs:
77
strategy:
88
matrix:
99
include:
10-
- ruby-version: 2.0.0
10+
- ruby-version: 2.3.8
1111
rails-version: 3
1212
- ruby-version: 2.3.8
1313
rails-version: 40
@@ -33,7 +33,8 @@ jobs:
3333
with:
3434
ruby-version: ${{ matrix.ruby-version }}
3535
bundler-cache: true
36+
bundler: '1.17.3'
3637

3738
- name: Run tests
3839
run: |
39-
bundle exec appraisal rails_${{ matrix.rails-version }} rspec
40+
bundle exec rake spec

Appraisals

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
# to test against all, run: appraisal rake spec
44

55
if RUBY_VERSION <= '2.4'
6+
# to get a working ruby 2.3: `docker run --rm -it --volume $PWD:/app ruby:2.3-stretch bash`
67
appraise 'rails-3' do
78
gem 'rails', '~>3.2.22'
89
gem 'test-unit'

Gemfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ source 'https://rubygems.org'
66
# NB: all other non-listed gems should go into Appraisals,
77
# this file is only for quick tests
88

9-
unless defined?(Appraisal)
9+
unless defined?(Appraisal) || RUBY_VERSION < '2.6'
1010
# rails should be included before us
1111
gem 'rails', '~>5.2.6'
1212
gem 'simplecov', require: false

gemfiles/rails_3.gemfile

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,6 @@
33
source "https://rubygems.org"
44

55
gem "rails", "~>3.2.22"
6-
gem "simplecov", require: false
7-
gem "sprockets"
8-
gem "sass"
96
gem "test-unit"
107

118
gemspec path: "../"

gemfiles/rails_40.gemfile

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,5 @@
33
source "https://rubygems.org"
44

55
gem "rails", "~>4.0.0"
6-
gem "simplecov", require: false
7-
gem "sprockets"
8-
gem "sass"
96

107
gemspec path: "../"

gemfiles/rails_42.gemfile

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,5 @@
33
source "https://rubygems.org"
44

55
gem "rails", "~>4.2.0"
6-
gem "simplecov", require: false
7-
gem "sprockets"
8-
gem "sass"
96

107
gemspec path: "../"

routes_coverage.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ Gem::Specification.new do |spec|
2626
spec.require_paths = ["lib"]
2727

2828
spec.add_development_dependency 'appraisal'
29-
spec.add_development_dependency "bundler", ">= 2.2.10"
29+
spec.add_development_dependency "bundler" #, ">= 2.2.10"
3030
spec.add_development_dependency "minitest"
3131
spec.add_development_dependency "rake", ">= 12.3.3"
3232
end

0 commit comments

Comments
 (0)