Merge pull request #4 from Vasfed/rails7_support

Support for rails 7

Author: Vasfed

.github/workflows/test.yml

@@ -6,22 +6,30 @@ jobs:
 
     strategy:
       matrix:
+        # lockfiles are not commited, so autodetection will not work, need to specify bundler version
         include:
           - ruby-version: 2.3.8
             rails-version: 3
+            bundler-version: 1.17.3
           - ruby-version: 2.3.8
             rails-version: 40
+            bundler-version: 1.17.3
           - ruby-version: 2.3.8
             rails-version: 42
+            bundler-version: 1.17.3
 
           - ruby-version: 2.3.8
             rails-version: 50_rspec
+            bundler-version: default
           - ruby-version: 2.6.9
             rails-version: 50_simplecov
+            bundler-version: default
           - ruby-version: 2.7.5
             rails-version: 6
-          # - ruby-version: 2.7.5
-          #   rails-version: 70
+            bundler-version: default
+          - ruby-version: 3.1.2
+            rails-version: 7
+            bundler-version: default
 
     env:
       BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/rails_${{ matrix.rails-version }}.gemfile
@@ -33,7 +41,7 @@ jobs:
         with:
           ruby-version: ${{ matrix.ruby-version }}
           bundler-cache: true
-          bundler: '1.17.3'
+          bundler: ${{ matrix.bundler-version }}
 
       - name: Run tests
         run: |

Appraisals

@@ -38,4 +38,8 @@ else
   appraise 'rails-6' do
     gem 'rails', '~>6.0.4'
   end
+
+  appraise 'rails-7' do
+    gem 'rails', '~>7.0.2'
+  end
 end

gemfiles/rails_7.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "~>7.0.2"
+
+gemspec path: "../"

lib/routes_coverage/auditor.rb

@@ -37,6 +37,10 @@ def controller_class_by_name(controller_name)
       controllers_hash[controller_name] ||= "#{controller_name}_controller".classify.constantize
       logger.warn "Controller #{controller_name} was not collected, but exists"
       controllers_hash[controller_name]
+    rescue ArgumentError => e
+      @missing_controllers << controller_name
+      logger.warn "Controller #{controller_name} failed to load: #{e}"
+      nil
     rescue NameError
       @missing_controllers << controller_name
       logger.warn "Controller #{controller_name} looks not existing"

spec/main_spec.rb

@@ -105,7 +105,7 @@ def run_dummy_rspec(testfile = 'dummy_rspec.rb')
   end
 
   it "working mounted engines, including Sprockets" do
-    skip if Rails.version < '4'
+    skip if Rails.version < '4' || Rails.version >= '7'
     res, code = run_dummy_test 'sprockets_test.rb'
     assert(code.success?)
     assert_match(/Routes coverage is (\d+(.\d+)?)%/, res)
@@ -132,15 +132,23 @@ def run_dummy_rspec(testfile = 'dummy_rspec.rb')
     assert_includes(res, "Controller somespace/foo looks not existing")
     assert_includes(res, "Controller otherspace/bar looks not existing")
     assert_includes(res, "Controller subdomain_route looks not existing")
-    assert_includes(res, "Missing 6 actions:")
 
-    _, missing_actions = res.split("Missing 6 actions:\n", 2)
-    assert_equal(<<~TXT, missing_actions)
+    expected_count = 6
+    expected_output = <<~TXT
       dummy: create, except: %i[new create show edit destroy], only: %i[index update] ,  Missing custom: some_custom, not_found_error
       somespace/foo: index, except: %i[index new create show edit update destroy], only: %i[]
       otherspace/bar: index, except: %i[index new create show edit update destroy], only: %i[]
       subdomain_route: index, except: %i[index new create show edit update destroy], only: %i[]
     TXT
+
+    if res.include?('Controller rails/welcome failed to load') # rails 7 has bug
+      expected_count = 7
+      expected_output += "rails/welcome: index, except: %i[index new create show edit update destroy], only: %i[]\n"
+    end
+
+    assert_includes(res, "Missing #{expected_count} actions:")
+    _, missing_actions = res.split("Missing #{expected_count} actions:\n", 2)
+    assert_equal(expected_output, missing_actions)
   end
 
   if defined? RSpec