Merge pull request #2 from Vasfed/github_actions

Replace travis with github actions

Author: Vasfed

.github/workflows/test.yml

@@ -0,0 +1,40 @@
+name: Test
+on: [push]
+jobs:
+  runTests:
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        include:
+          - ruby-version: 2.3.8
+            rails-version: 3
+          - ruby-version: 2.3.8
+            rails-version: 40
+          - ruby-version: 2.3.8
+            rails-version: 42
+
+          - ruby-version: 2.3.8
+            rails-version: 50_rspec
+          - ruby-version: 2.6.9
+            rails-version: 50_simplecov
+          - ruby-version: 2.7.5
+            rails-version: 6
+          # - ruby-version: 2.7.5
+          #   rails-version: 70
+
+    env:
+      BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/rails_${{ matrix.rails-version }}.gemfile
+
+    steps:
+      - uses: actions/checkout@master
+      - name: Install ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+          bundler-cache: true
+          bundler: '1.17.3'
+
+      - name: Run tests
+        run: |
+          bundle exec rake spec

.travis.yml

@@ -3,6 +3,7 @@
 # to test against all, run: appraisal rake spec
 
 if RUBY_VERSION <= '2.4'
+  # to get a working ruby 2.3: `docker run --rm -it --volume $PWD:/app ruby:2.3-stretch bash`
   appraise 'rails-3' do
     gem 'rails', '~>3.2.22'
     gem 'test-unit'

Appraisals

@@ -6,7 +6,7 @@ source 'https://rubygems.org'
 # NB: all other non-listed gems should go into Appraisals,
 # this file is only for quick tests
 
-unless defined?(Appraisal)
+unless defined?(Appraisal) || RUBY_VERSION < '2.6'
   # rails should be included before us
   gem 'rails', '~>5.2.6'
   gem 'simplecov', require: false

Gemfile

@@ -3,9 +3,6 @@
 source "https://rubygems.org"
 
 gem "rails", "~>3.2.22"
-gem "simplecov", require: false
-gem "sprockets"
-gem "sass"
 gem "test-unit"
 
 gemspec path: "../"

gemfiles/rails_3.gemfile

@@ -3,8 +3,5 @@
 source "https://rubygems.org"
 
 gem "rails", "~>4.0.0"
-gem "simplecov", require: false
-gem "sprockets"
-gem "sass"
 
 gemspec path: "../"

gemfiles/rails_40.gemfile

@@ -3,8 +3,5 @@
 source "https://rubygems.org"
 
 gem "rails", "~>4.2.0"
-gem "simplecov", require: false
-gem "sprockets"
-gem "sass"
 
 gemspec path: "../"

gemfiles/rails_42.gemfile

@@ -170,15 +170,15 @@ def self._collect_route_groups(all_routes)
             when :constraints
               value.all? do |constraint_name, constraint_value|
                 if constraint_value.present?
-                  route.constraints[constraint_name] && route.constraints[constraint_name].match?(constraint_value)
+                  route.constraints[constraint_name] && route.constraints[constraint_name].match(constraint_value)
                 else
                   route.constraints[constraint_name].blank?
                 end
               end
             end
           end
         else
-          route.path.spec.to_s.match?(matcher)
+          route.path.spec.to_s.match(matcher)
         end
       end
 
@@ -197,9 +197,9 @@ def self._touch_request(req)
       else # rails < 4.2
         dispatcher = route.app
         req.env['action_dispatch.request.path_parameters'] =
-          (env['action_dispatch.request.path_parameters'] || {}).merge(parameters)
+          (req.env['action_dispatch.request.path_parameters'] || {}).merge(parameters)
         while dispatcher.is_a?(ActionDispatch::Routing::Mapper::Constraints)
-          dispatcher = (dispatcher.app if dispatcher.matches?(env))
+          dispatcher = (dispatcher.app if dispatcher.matches?(req.env))
         end
       end
       next unless dispatcher

lib/routes_coverage.rb

@@ -95,8 +95,10 @@ def expected_routes
         namespaces_regex = Regexp.union(@settings.exclude_namespaces.map { |n| %r{^/#{n}} })
 
         routes_groups = all_routes.group_by do |r|
+          # rails <=4 has regex in verb
+          verb = r.verb.is_a?(Regexp) && r.verb.inspect.gsub(/[^\w]/, '') || r.verb
           (
-            ("#{r.verb.to_s[8..-3]} #{r.path.spec}".strip =~ filter_regex) ||
+            ("#{verb} #{r.path.spec}".strip =~ filter_regex) ||
             (r.path.spec.to_s =~ namespaces_regex)
           ).present?
         end

lib/routes_coverage/result.rb

@@ -26,7 +26,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_development_dependency 'appraisal'
-  spec.add_development_dependency "bundler", ">= 2.2.10"
+  spec.add_development_dependency "bundler" #, ">= 2.2.10"
   spec.add_development_dependency "minitest"
   spec.add_development_dependency "rake", ">= 12.3.3"
 end