-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pleas make lm-sensors available in runtime environment #557
Comments
Where does lm-sensors get its information from? Adding executables to the container doesn't add value unless they have everything they need to do their job. In the case of lm-sensors, does that mean /sys, or /dev, or somewhere else? Does it have/need configuration? Running a command-line program with human-readable output, and screen-scraping its output with grep or similar, is an inefficient and fragile way to get information, particularly if it's being done every few frames in something like MangoHud: launching an executable (or multiple executables for a shell pipeline) involves a lot more syscalls and I/O than calling a function, and small changes to the formatting of human-readable text can easily break field extraction. In general I'd prefer it if tools like MangoHud were using a programmatic interface like libsensors - although the ABI of libsensors changes periodically (it's currently at If using the command-line tool is unavoidable, it would be more reliable to use Alternatively, if the overlay that shows sensor results doesn't need to be in-process with the actual game, having it be a separate process that is composited over the top of the actual game (perhaps integrated with Gamescope) would ensure it doesn't interfere with running the game itself, would ensure that it can update even if the game is frozen, and would let it run on the host system instead of inside the game's container. |
Thanks for taking your time to look into this! Unfortunately I can't answer most of your technical questions - sorry! This proposal was meant to be a band-aid as long as the feature is not available via MangoHud code. |
Probably yes, but if we do that and games start relying on it being there, then we have to keep it working forever, even if it breaks because the information it needs to read from /sys has changed - so that's a bigger thing to ask for than you might first think. |
Understood. |
Not easily. If you have Flatpak installed (which the Deck does), you could use |
Feature Request
I confirm:
contain this feature already.
Description
Please include the lm-sensors binary so we are able to display additional sensor information in MangoHud.
References [optional]
flightlessmango/MangoHud#848
The text was updated successfully, but these errors were encountered: