Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect plane calculation in IntersectRayWithOBB #552

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samisalreadytaken
Copy link

@samisalreadytaken samisalreadytaken commented Aug 27, 2022

Hull trace against an OBB erroneously transforms calculated normal from world to local space instead of local to world.

This code is referenced in SweepBoxToStudio (bone_setup.cpp) > TraceToStudio > CBaseAnimating::TestHitboxes(); however it is not reached in existing SDK code because hull traces are not used.

Bitl referenced this pull request in FIREFIGHT-RELOADED/FIREFIGHT-RELOADED-src-sdk-2013 Mar 10, 2023
Baklojan added a commit to Baklojan/source-sdk-2013-old that referenced this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant