convert sprintf calls to snprintf #267
Conversation
Partly addresses:
mac build provokes warnings
ValveSoftware#266
Many implementations have deprecated sprintf() in favor of snprintf(), including
macOS with latest Xcode and Windows if _CRT_SECURE_NO_WARNINGS is set.
This change converts all uses of sprintf() to snprintf(). In most cases this is
simply converting
sprintf(x, ...)
to
snprintf(x, sizeof(x), ...)
But there are a few more complicated constructions in fossilize_replay.cpp,
fossilize_db.cpp, and layer/instance.cpp.
|
Does this actually unblock something, or is it purely to avoid warnings? |
|
I am 99% this is purely a warning and just reporting to "fix it now before it causes issues down the road" |
I'm 100% sure. :-) Nothing is blocked (though we did have to alter the SDK build for this repository to turn off "warnings-are-errors" in order to unblock). The warning that I would not be concerned if smart people like y'all decided this wasn't ever going to be a real issue, and decided to close the PR without merge. (I only made a PR because I'd gone through the effort to analyze the warnings after they first broke the SDK build, and I thought I understood at that point how to fix them, and thought it would be a shame to just drop them.) |
Partly addresses:
Many implementations have deprecated sprintf() in favor of snprintf(), including macOS with latest Xcode and Windows if _CRT_SECURE_NO_WARNINGS is set.
This change converts all uses of sprintf() to snprintf(). In most cases this is simply converting
sprintf(x, ...)
to
snprintf(x, sizeof(x), ...)
But there are a few more complicated constructions in fossilize_replay.cpp, fossilize_db.cpp, and layer/instance.cpp.