Rewrote event system to use scriptable objects instead. Allows easier adding of future events

Author: ValentinGurkov

Attributes/Health.cs

@@ -27,7 +27,7 @@ public class Health : MonoBehaviour, ISaveable {
         public class TakeDamageEvent : UnityEvent<float> { }
 
         [System.Serializable]
-        public class OnDieEvent : UnityEvent<Health> { }
+        public class OnDieEvent : UnityEvent<String> { }
 
         public bool IsDead { get; private set; } = false;
         public float Percentage => Fraction * 100;
@@ -69,7 +69,7 @@ public void TakeDamage(GameObject instigator, float damage) {
             takeDamage?.Invoke(damage);
             onHealthUpdate?.Invoke();
             if (healthPoints.value == 0) {
-                onDie?.Invoke(this);
+                onDie?.Invoke(gameObject.name);
                 Die();
                 AwardExperience(instigator);
             }

Combat/PickupBase.cs

@@ -8,10 +8,10 @@ namespace RPG.Combat {
     public class PickupBase : MonoBehaviour, IRaycastable {
         private Collider objectCollider;
 
-        [SerializeField] private OnPickupEvent onPickup;
+        [SerializeField] public OnPickupEvent onPickUp;
 
         [System.Serializable]
-        public class OnPickupEvent : UnityEvent<PickupBase> { }
+        public class OnPickupEvent : UnityEvent<string> { }
 
         public CursorType Cursor => CursorType.Pickup;
 
@@ -38,7 +38,8 @@ protected void Pickup(bool respawnable, float respawnTime) {
             } else {
                 Destroy(gameObject);
             }
-            onPickup?.Invoke(this);
+
+            onPickUp?.Invoke(gameObject.name);
         }
 
         public bool HandleRaycast(GameObject callingObject) {

Events/Editor.meta

@@ -0,0 +1,19 @@
+using UnityEditor;
+using UnityEngine;
+
+namespace RPG.Events {
+    [CustomEditor(typeof(GameEvent))]
+    public class EventEditor : Editor {
+        public override void OnInspectorGUI() {
+            base.OnInspectorGUI();
+
+            GUI.enabled = Application.isPlaying;
+
+            GameEvent e = target as GameEvent;
+            if (GUILayout.Button("Raise")) {
+                e.Raise("Raise");
+            }
+
+        }
+    }
+}

Events/Editor/EventEditor.cs

@@ -0,0 +1,33 @@
+using System.Collections.Generic;
+using UnityEngine;
+
+namespace RPG.Events {
+    [CreateAssetMenu(fileName = "GameEvent", menuName = "Events/New Game Event", order = 0)]
+    public class GameEvent : ScriptableObject {
+        /// <summary>
+        /// The list of listeners that this event will notify if it is raised.
+        /// </summary>
+        private readonly List<GameEventListener> eventListeners =
+            new List<GameEventListener>();
+
+        public void Raise(string something) {
+            for (int i = eventListeners.Count - 1; i >= 0; i--) {
+                eventListeners[i].OnEventRaised(something);
+            }
+
+        }
+
+        public void RegisterListener(GameEventListener listener) {
+            if (!eventListeners.Contains(listener)) {
+                eventListeners.Add(listener);
+            }
+
+        }
+
+        public void UnregisterListener(GameEventListener listener) {
+            if (eventListeners.Contains(listener)) {
+                eventListeners.Remove(listener);
+            }
+        }
+    }
+}

Events/EventSystem.cs.meta Events/Editor/EventEditor.cs.metaEvents/EventSystem.cs.meta renamed to Events/Editor/EventEditor.cs.meta

@@ -0,0 +1,27 @@
+using UnityEngine;
+using UnityEngine.Events;
+
+namespace RPG.Events {
+    public class GameEventListener : MonoBehaviour {
+        [Tooltip("Event to register with.")]
+        public GameEvent Event;
+
+        [Tooltip("Response to invoke when Event is raised.")]
+        public StringEvent Response;
+
+        [System.Serializable]
+        public class StringEvent : UnityEvent<string> { }
+
+        private void OnEnable() {
+            Event.RegisterListener(this);
+        }
+
+        private void OnDisable() {
+            Event.UnregisterListener(this);
+        }
+
+        public void OnEventRaised(string context) {
+            Response.Invoke(context);
+        }
+    }
+}