Generalize TA::squared_norm
#459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evaleev
reviewed
Jun 26, 2024
| @@ -1917,7 +1943,7 @@ auto inner_product(const DistArray<Tile, Policy>& a, | |||
|
|
|||
| template <typename Tile, typename Policy> | |||
| auto squared_norm(const DistArray<Tile, Policy>& a) { | |||
| return a(detail::dummy_annotation(rank(a))).squared_norm(); | |||
| return a.make_tsrexpr(detail::dummy_annotation(rank(a))).squared_norm(); | |||
There was a problem hiding this comment.
why only this unary reduction converted to make_tsrexpr?
evaleev
requested changes
Jun 26, 2024
| return (a(detail::dummy_annotation(rank(a))) | ||
| .dot(b(detail::dummy_annotation(rank(b))))) | ||
| .get(); | ||
| auto&& expr_a = a.make_tsrexpr(detail::dummy_annotation(rank(a))); |
There was a problem hiding this comment.
you don't want to use make_tsrexpr for binary reductions
There was a problem hiding this comment.
That was my initial thought too. However, this .dot method already assumed the layout of both arguments to be congruent. On the same footing, make_tsrexpr should be a valid choice here.
evaleev
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.