Skip to content

command line mode refactoring#5

Merged
guillermooo merged 3 commits into
masterfrom
ex-mode
Nov 16, 2015
Merged

command line mode refactoring#5
guillermooo merged 3 commits into
masterfrom
ex-mode

Conversation

@guillermooo
Copy link
Copy Markdown
Member

@guillermooo guillermooo commented Nov 16, 2015

Refactoring for simpler code. (I hope.)

@guillermooo guillermooo changed the title command line mode command line mode refactoring Nov 16, 2015
@jpoon
Copy link
Copy Markdown
Member

jpoon commented Nov 16, 2015

@guillermooo would you mind squashing your commits? git rebase -i HEAD~10 to squash the last 10 commits.

@guillermooo
Copy link
Copy Markdown
Member Author

guillermooo commented Nov 16, 2015

sure

@guillermooo
Copy link
Copy Markdown
Member Author

guillermooo commented Nov 16, 2015

@jpoon I still have a bunch of default headers and tabs in the files. I can try cleaning that up and squashing again. Or do it later.

@jpoon
Copy link
Copy Markdown
Member

jpoon commented Nov 16, 2015

I'm a neat freak so I setup gulp+tslint on a private branch and we have a bunch of errors :(. Didn't bother with fixing them as (1) there were a lot and (2) Connect() is coming up fast.

We can start taking care of the engineering debt when we have some basic stuff working?

@guillermooo
Copy link
Copy Markdown
Member Author

guillermooo commented Nov 16, 2015

I'm learning TS as I go, so you better wait some more. :) So 👍 to paying debt off later. When we look into that, we should setup CI integration with Travis and Appveyor to run the test suite. I suppose we can output the test results to a file somehow.

I will try to fix the basic stuff such as whitespace now, though.

@guillermooo
Copy link
Copy Markdown
Member Author

guillermooo commented Nov 16, 2015

Well, I took a look at tslint issues and actually fixed them already.

@jpoon
Copy link
Copy Markdown
Member

jpoon commented Nov 16, 2015

👍 Feel free to merge. I believe you should have that green button enabled.

guillermooo added a commit that referenced this pull request Nov 16, 2015
@guillermooo
Merge pull request #5 from VSCode-Extension/ex-mode
974dab8 
command line mode refactoring
@guillermooo guillermooo merged commit 974dab8 into master Nov 16, 2015
@guillermooo guillermooo deleted the ex-mode branch November 17, 2015 07:23
AlexTalker added a commit to AlexTalker/VSCodeVim that referenced this pull request Apr 21, 2025
@AlexTalker
Debug VSCodeVim#5
7ac139a
AlexanderFarkas added a commit to AlexanderFarkas/Vim that referenced this pull request May 2, 2026
@AlexanderFarkas @claude
review: fix <C-Right>/<C-Left> WORD/word, <S-Up>/<S-Down> no-op, R<C-o>
96dd1d7 
- <C-Right>/<C-Left> now dispatch to MoveWordBegin/MoveBeginningWord (small
  word `w`/`b`), matching :help <C-Right> and the <C-S-Right> sibling. Drops
  the dead-shadow `<C-right>`/`<C-left>` aliases on MoveFullWordBegin and
  MoveBeginningWord (same key-collision pattern that originally hid <C-BS>).
- Adds inverse-gated MoveShiftUpAsPage/MoveShiftDownAsPage so <S-Up>/<S-Down>
  fall back to <C-B>/<C-F> page motion when keymodel lacks startsel
  (matches :help <S-Up>); previously a silent no-op.
- ExecuteOneNormalCommandInInsertMode now registered for Mode.Replace and
  captures the actual current mode as the return target. R<C-o>w returns to
  Replace; (replace) NORMAL/VISUAL/VISUAL LINE/VISUAL BLOCK pseudo-modes
  reachable end-to-end.

Red tests in pr9998Regressions.test.ts (Bug VSCodeVim#5/6/7); un-skipped three R<C-o>
cases in pseudoModes.test.ts.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@guillermooo @jpoon