Skip to content

Adopt latest list navigation support #3432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 1, 2019
Merged

Adopt latest list navigation support #3432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
574440b
adopt list navigation support
joaomoreno Jan 31, 2019
beb8b06
remove gallery metadata
joaomoreno Feb 1, 2019
f99f489
Merge remote-tracking branch 'upstream/master' into adopt-list-naviga…
joaomoreno Feb 1, 2019
4185afc
whitespace
joaomoreno Feb 1, 2019
6c6c705
forceprettier
joaomoreno Feb 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,10 @@ export async function activate(context: vscode.ExtensionContext) {
mh.updateView(mh.vimState, { drawSelection: false, revealRange: false });
}

// Disable automatic keyboard navigation in lists, so it doesn't interfere
// with our list navigation keybindings
await VsCodeContext.Set('listAutomaticKeyboardNavigation', false);

await toggleExtension(configuration.disableExtension, compositionState);

logger.debug('Finish.');
Expand Down
5 changes: 5 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,11 @@
"command": "list.toggleExpand",
"when": "listFocus && !inputFocus"
},
{
"key": "/",
"command": "list.toggleKeyboardNavigation",
"when": "listFocus && !inputFocus && listSupportsKeyboardNavigation"
},
{
"key": "ctrl+a",
"command": "extension.vim_ctrl+a",
Expand Down
2 changes: 1 addition & 1 deletion test/configuration/configuration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ suite('Configuration', () => {
});

test('neovim disabled on missing path', async () => {
assert.equal(false, srcConfiguration.configuration.enableNeovim)
assert.equal(false, srcConfiguration.configuration.enableNeovim);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes, thanks for fixing this.

});

newTest({
Expand Down