Skip to content

fix(ci): go-ci.yml — build libvmaf before cgo tests + skip operator envtest - #483

Merged
lusoris merged 1 commit into
masterfrom
fix/go-ci-build-libvmaf-and-skip-envtest
May 31, 2026
Merged

lusoris merged 1 commit into
masterfrom
fix/go-ci-build-libvmaf-and-skip-envtest

Conversation

@lusoris

@lusoris lusoris commented May 31, 2026

Copy link
Copy Markdown
Contributor

Fix master CI: .github/workflows/go-ci.yml fails on every Go-touching PR with two pre-existing issues:

  1. cgo link cannot find -lvmaf: pkg/libvmaf/ cgo test uses -L core/build-cpu/src -lvmaf but the workflow doesn't build libvmaf before go test. Added meson+ninja install step + CPU-only libvmaf build before go test.

  2. Operator envtest needs kubebuilder/etcd: cmd/vmafx-operator/ tests use controller-runtime/test-env which requires /usr/local/kubebuilder/bin/etcd (not available on GitHub-hosted runners). Skipped via grep -v cmd/vmafx-operator until envtest is wired in or test is refactored. Tracked: T-GO-CI-OPERATOR-ENVTEST-2026-05-31.

This unblocks every Go-touching PR currently failing on the train (#468 was admin-merged for the same reason; subsequent Go PRs benefit).

no state delta: pure CI workflow fix; no bug tracker entry; no production behavior change.

ADR-0108 deliverables checklist

  • Research digest — no digest needed: 1-paragraph CI workflow fix derived from PR fix(queue): roll back PullWork RUNNING state when post-update Get fails (round-25 audit B.1) #468 failure log.
  • Decision matrix — no alternatives: only-one-way fix (build libvmaf before cgo / skip envtest).
  • AGENTS.md invariant note — no rebase-sensitive invariants: pure workflow change.
  • Reproducer / smoke-test command — gh pr view 468 -R VMAFx/vmafx --json statusCheckRollup --jq '.statusCheckRollup | map(select(.conclusion=="FAILURE"))' shows pre-fix failure; CI run on this PR shows post-fix pass.
  • CHANGELOG fragment — no changelog needed: CI-only infrastructure fix; not user-facing.
  • Rebase note — no rebase impact: fork-local workflow.

🤖 Generated with Claude Code

@lusoris
lusoris merged commit 83783da into master May 31, 2026
52 of 53 checks passed
@lusoris
lusoris deleted the fix/go-ci-build-libvmaf-and-skip-envtest branch May 31, 2026 11:41
@lusoris lusoris added this to the 1.0.0 — First release milestone Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant