Repository navigation
fix(ci): go-ci.yml — build libvmaf before cgo tests + skip operator envtest - #483
Merged
Merged
Conversation
…nvtest (round-25 master CI follow-up)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix master CI:
.github/workflows/go-ci.ymlfails on every Go-touching PR with two pre-existing issues:cgo link
cannot find -lvmaf:pkg/libvmaf/cgo test uses-L core/build-cpu/src -lvmafbut the workflow doesn't build libvmaf beforego test. Added meson+ninja install step + CPU-only libvmaf build beforego test.Operator envtest needs kubebuilder/etcd:
cmd/vmafx-operator/tests usecontroller-runtime/test-envwhich requires/usr/local/kubebuilder/bin/etcd(not available on GitHub-hosted runners). Skipped viagrep -v cmd/vmafx-operatoruntil envtest is wired in or test is refactored. Tracked:T-GO-CI-OPERATOR-ENVTEST-2026-05-31.This unblocks every Go-touching PR currently failing on the train (#468 was admin-merged for the same reason; subsequent Go PRs benefit).
no state delta: pure CI workflow fix; no bug tracker entry; no production behavior change.ADR-0108 deliverables checklist
gh pr view 468 -R VMAFx/vmafx --json statusCheckRollup --jq '.statusCheckRollup | map(select(.conclusion=="FAILURE"))'shows pre-fix failure; CI run on this PR shows post-fix pass.🤖 Generated with Claude Code