Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Itowns folder #584

Closed
5 tasks done
valentinMachado opened this issue Mar 24, 2023 · 2 comments · Fixed by #612
Closed
5 tasks done

Clean Itowns folder #584

valentinMachado opened this issue Mar 24, 2023 · 2 comments · Fixed by #612
Labels
clean up Code has to be modifed but not functionally itowns This issue required changes in itowns priority-high

Comments

@valentinMachado
Copy link
Contributor

valentinMachado commented Mar 24, 2023

This issue aim to clean the folder packages/browser/src/Component/Itowns. The code in that folder is used by our Widget and propose some features to itowns framework, in order to contribute our widget in itowns/widget we have to:

  • add these features to itowns, if they are relevant/necessary
  • refacto our widget using exclusively itowns, if they are not

In anycase this folder should be "empty", or at least be considered as a "buffer of code" the time to mature it and to add it to itowns. Note that we could have a folder ItownsUtil where we could have code as AddLayerFromConfig which should not be in itowns (and not in our Widget) but is very useful in an @ud-viz/browser context (to create application).

As there are many code in that folder, I propose to open an issue for each folder/file in that folder, to discuss them one by one.

This thread is to keep a global track of this work. And to define where are priorities.

related #537

@valentinMachado
Copy link
Contributor Author

First issue that should be solve => #594

@valentinMachado
Copy link
Contributor Author

After discussion of #594 its appears to me that CityObject is not doing something functional (since batch id is an equivalent) and moreover can be confusing since other object in our pipeline are called cityobject and are not equivalent.

Since quite everything in the Itowns folder depends of CityObject quite everything have to be refactored.

Except StyleManager which is buffering a CityObjectStyle (that should be replace by the Style class of itowns) associated to a CityObject (that should be replace by batch id) here I have not found new feature to propose to itowns.

So here is what I going to do:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean up Code has to be modifed but not functionally itowns This issue required changes in itowns priority-high
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants