Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning if file was not taken into an account in a specific diffStep #69

Open
DAB0mB opened this issue Feb 27, 2018 · 3 comments
Open

Comments

@DAB0mB
Copy link
Collaborator

DAB0mB commented Feb 27, 2018

No description provided.

@dotansimha
Copy link
Collaborator

@DAB0mB can you please explain and give an example?

@DAB0mB
Copy link
Collaborator Author

DAB0mB commented Apr 18, 2018

I think @darkbasic told me about it originally so I'm not sure. I think that if we specify a file in the template helper and it wasn't rendered because it doesn't exist or .gitignored we should print it to the console. Would be nice to have a color to it so it won't mix with the other logs. Sounds very useful actualy

@darkbasic
Copy link
Contributor

Yeah pretty close to it. In fact in order to reduce the number of commits and the subsequent rebase burden I'm trying to split each commit in multiple ones simply by specifying the files that I want to render:

{{{ diffStep "3.1" module="client" files="src/app/chats-lister/components/chat-item/chat-item.component.spec.ts" }}}

{{{ diffStep "3.1" module="client" files="src/app/services/chats.service.spec.ts" }}}

{{{ diffStep "3.1" module="client" files="src/app/chats-lister/containers/chats/chats.component.spec.ts" }}}

The issue with this approach is that if you add a new file during rebases and you forget about adding it to the files list, you won't get it rendered. Unfortunately it happens 100% of times.
Something similar happened with the old Ionic tutorial, where I missed to render a whole step: I noticed only after people started complaining that the tutorial didn't work.

While rendering the views with tortilla manual render would be great to get a warning if something like that happens. Also I would love to have an ignore list, because for example I never render the package.json file: instead I simply type which packages the user needs to install and the related commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants