Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve JS security vulnerability in dependency #307

Closed
brlodi opened this issue May 14, 2018 · 3 comments · Fixed by #355
Closed

Resolve JS security vulnerability in dependency #307

brlodi opened this issue May 14, 2018 · 3 comments · Fixed by #355
Assignees

Comments

@brlodi
Copy link
Collaborator

brlodi commented May 14, 2018

The current version of node-sass depends on request 2.79.0, which in turn depends on a package with a known security vulnerability. More recent versions of request have resolved this, but have not yet been upgraded in node-sass.

This is tracked in sass/node-sass#2355 and will be resolved in the next server update of node-sass. We should upgrade our node-sass dependency in package.json at that time.

@brlodi brlodi self-assigned this May 14, 2018
@vforgione
Copy link
Member

Just want to revisit this. Did these imbeciles ever get their shit together?

@brlodi
Copy link
Collaborator Author

brlodi commented Jun 26, 2018

You'll note the blocking issue is still open. And this affects several packages we depend on, including Bootstrap itself, beyond our direct use of Sass. They know it's an issue, since every GitHub project depending on node-sass, directly or indirectly (e.g. through Angular), has the same lovely yellow box.

@brlodi
Copy link
Collaborator Author

brlodi commented Jun 27, 2018

For completeness, sass/node-sass#2312 and subsequent release is what we, and most of the rest of the JavaScript ecosystem, are waiting on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants