Skip to content

Commit 7322277

Browse files
UnsignedArduinoUnsignedArduino
committed
Remove type checking
Fixes #30
1 parent fe89e13 commit 7322277

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

47 files changed

+0
-1972
lines changed

‎Tests/test_Button.py

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,6 @@ def test_no_params(self):
1717
with self.assertRaises(TypeError):
1818
Button()
1919

20-
def test_bad_params(self):
21-
with self.assertRaises(TypeError):
22-
Button("asdf")
23-
with self.assertRaises(TypeError):
24-
Button(self.root, text=1)
25-
with self.assertRaises(TypeError):
26-
Button(self.root, image="foo")
27-
2820
def test_good_params(self):
2921
image_data = base64.b64decode("""Qk02MAAAAAAAADYAAAAoAAAAQAAAAEAAAAABABgAAAAAAAAwAAAAAA
3022
AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
@@ -251,8 +243,6 @@ def test_text(self):
251243
b.text = "Test"
252244
self.root.update()
253245
self.assertEqual(b.text, "Test")
254-
with self.assertRaises(TypeError):
255-
b.text = 1
256246

257247
def test_image(self):
258248
b = Button(self.root)
@@ -478,8 +468,6 @@ def test_image(self):
478468
b.image = PhotoImage(data=image_data)
479469
self.root.update()
480470
self.assertTrue(b.image is not None)
481-
with self.assertRaises(TypeError):
482-
b.image = "foo bar"
483471

484472
def test_text_and_image(self):
485473
b = Button(self.root, text="Click for smiles!")
@@ -712,8 +700,6 @@ def test_text_and_image(self):
712700
b.display_mode = DisplayModes.ImageTopText
713701
self.root.update()
714702
self.assertEqual(b.display_mode, DisplayModes.ImageTopText)
715-
with self.assertRaises(TypeError):
716-
b.display_mode = False
717703

718704
def test_enabled(self):
719705
b = Button(self.root)
@@ -722,8 +708,6 @@ def test_enabled(self):
722708
self.assertTrue(b.enabled)
723709
b.enabled = False
724710
self.assertFalse(b.enabled)
725-
with self.assertRaises(TypeError):
726-
b.enabled = 1
727711

728712
def test_hover(self):
729713
b = Button(self.root)
@@ -742,8 +726,6 @@ def test_style(self):
742726
background="red")
743727
b.apply_style("Test")
744728
self.assertEqual(b.cget("style"), "Test.TButton")
745-
with self.assertRaises(TypeError):
746-
b.apply_style(1)
747729

748730

749731
if __name__ == '__main__':

‎Tests/test_Checkbutton.py

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -13,24 +13,6 @@
1313

1414

1515
class CheckbuttonTest(TkTestCase):
16-
def test_no_params(self):
17-
with self.assertRaises(TypeError):
18-
Checkbutton()
19-
with self.assertRaises(TypeError):
20-
Checkbutton(1)
21-
with self.assertRaises(TypeError):
22-
Checkbutton(self.root, text=lambda: None)
23-
with self.assertRaises(TypeError):
24-
Checkbutton(self.root, image="lol")
25-
26-
def test_bad_params(self):
27-
with self.assertRaises(TypeError):
28-
Checkbutton(1)
29-
with self.assertRaises(TypeError):
30-
Checkbutton(self.root, text=lambda: None)
31-
with self.assertRaises(TypeError):
32-
Checkbutton(self.root, image="lol")
33-
3416
def test_good_params(self):
3517
image_data = base64.b64decode("""Qk02MAAAAAAAADYAAAAoAAAAQAAAAEAAAAABABgAAAAAAAAwAAAAAA
3618
AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
@@ -262,17 +244,13 @@ def test_value(self):
262244
c.value = None
263245
self.root.update()
264246
self.assertEqual(c.value, None)
265-
with self.assertRaises(TypeError):
266-
c.value = 1
267247

268248
def test_text(self):
269249
c = Checkbutton(self.root, text="Foobar")
270250
c.grid(row=0, column=0)
271251
c.text = "Test"
272252
self.root.update()
273253
self.assertEqual(c.text, "Test")
274-
with self.assertRaises(TypeError):
275-
c.text = 1234
276254

277255
def test_image(self):
278256
c = Checkbutton(self.root)
@@ -498,8 +476,6 @@ def test_image(self):
498476
c.image = PhotoImage(data=image_data)
499477
self.root.update()
500478
self.assertTrue(c.image is not None)
501-
with self.assertRaises(TypeError):
502-
c.image = "lalalalala"
503479

504480
def test_text_and_image(self):
505481
c = Checkbutton(self.root, text="Click for smiles!")
@@ -732,8 +708,6 @@ def test_text_and_image(self):
732708
c.display_mode = DisplayModes.ImageTopText
733709
self.root.update()
734710
self.assertEqual(c.display_mode, DisplayModes.ImageTopText)
735-
with self.assertRaises(TypeError):
736-
c.display_mode = ["la", "la"]
737711

738712
def test_enabled(self):
739713
c = Checkbutton(self.root)
@@ -742,8 +716,6 @@ def test_enabled(self):
742716
self.assertTrue(c.enabled)
743717
c.enabled = False
744718
self.assertFalse(c.enabled)
745-
with self.assertRaises(TypeError):
746-
c.enabled = {"boo"}
747719

748720
def test_hover(self):
749721
c = Checkbutton(self.root)
@@ -764,8 +736,6 @@ def test_style(self):
764736
c.apply_style("Test")
765737
self.root.update()
766738
self.assertEqual(c.cget("style"), "Test.TCheckbutton")
767-
with self.assertRaises(TypeError):
768-
c.apply_style(1)
769739

770740

771741
if __name__ == '__main__':

‎Tests/test_Combobox.py

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -10,20 +10,6 @@
1010

1111

1212
class ComboboxTest(TkTestCase):
13-
def test_no_params(self):
14-
with self.assertRaises(TypeError):
15-
Combobox()
16-
17-
def test_bad_params(self):
18-
with self.assertRaises(TypeError):
19-
Combobox(1)
20-
with self.assertRaises(TypeError):
21-
Combobox(self.root, values={})
22-
with self.assertRaises(TypeError):
23-
Combobox(self.root, width=5.5)
24-
with self.assertRaises(TypeError):
25-
Combobox(self.root, show=False)
26-
2713
def test_good_params(self):
2814
Combobox(self.root, width=20, show="*", values=("foo", "bar"),
2915
command=lambda: print("Changed"),
@@ -36,8 +22,6 @@ def test_value(self):
3622
self.assertEqual(c.value, "")
3723
c.value = "Foo"
3824
self.assertEqual(c.value, "Foo")
39-
with self.assertRaises(TypeError):
40-
c.value = 1
4125

4226
def test_values(self):
4327
# Also fails randomly in GitHub actions
@@ -50,8 +34,6 @@ def test_values(self):
5034
self.assertEqual(c.values, ("Foo", ))
5135
c.values = ["Bar"]
5236
self.assertEqual(c.values, ("Bar", ))
53-
with self.assertRaises(TypeError):
54-
c.values = {}
5537
except tk.TclError:
5638
pass
5739

@@ -62,8 +44,6 @@ def test_enabled(self):
6244
self.assertTrue(c.enabled)
6345
c.enabled = False
6446
self.assertFalse(c.enabled)
65-
with self.assertRaises(TypeError):
66-
c.enabled = "lala"
6747

6848
def test_read_only(self):
6949
c = Combobox(self.root)
@@ -72,8 +52,6 @@ def test_read_only(self):
7252
self.assertFalse(c.read_only)
7353
c.read_only = True
7454
self.assertTrue(c.read_only)
75-
with self.assertRaises(TypeError):
76-
c.read_only = 1
7755

7856
def test_hover(self):
7957
c = Combobox(self.root)
@@ -119,8 +97,6 @@ def test_style(self):
11997
c.apply_style("Test")
12098
self.assertEqual(c.cget("style"), "Test.TCombobox")
12199
self.root.update()
122-
with self.assertRaises(TypeError):
123-
c.apply_style([bool])
124100

125101

126102
if __name__ == '__main__':

‎Tests/test_Dialog.py

Lines changed: 0 additions & 112 deletions
Original file line numberDiff line numberDiff line change
@@ -26,15 +26,6 @@ def test_open_file_good_params(self):
2626
# running as batch of unit tests.
2727
pass
2828

29-
def test_open_file_bad_params(self):
30-
self.root.after(ms=1000, func=lambda: self.root.close())
31-
with self.assertRaises(TypeError):
32-
Dialog.open_file(initial_dir=1)
33-
with self.assertRaises(TypeError):
34-
Dialog.open_file(title=lambda: None)
35-
with self.assertRaises(TypeError):
36-
Dialog.open_file(file_types=[0, 0, 0])
37-
3829
def test_save_file_no_params(self):
3930
self.root.after(ms=1000, func=lambda: self.root.close())
4031
Dialog.save_file()
@@ -45,15 +36,6 @@ def test_save_file_good_params(self):
4536
file_types=(("Text files", "*.txt"),
4637
("All files", "*.*")))
4738

48-
def test_save_file_bad_params(self):
49-
self.root.after(ms=1000, func=lambda: self.root.close())
50-
with self.assertRaises(TypeError):
51-
Dialog.save_file(initial_dir=1)
52-
with self.assertRaises(TypeError):
53-
Dialog.save_file(title=lambda: None)
54-
with self.assertRaises(TypeError):
55-
Dialog.save_file(file_types=[0, 0, 0])
56-
5739
def test_select_directory_no_params(self):
5840
self.root.after(ms=1000, func=lambda: self.root.close())
5941
Dialog.select_directory()
@@ -62,13 +44,6 @@ def test_select_directory_good_params(self):
6244
self.root.after(ms=1000, func=lambda: self.root.close())
6345
Dialog.select_directory(initial_dir=Path.cwd(), title="Foo bar")
6446

65-
def test_select_directory_bad_params(self):
66-
self.root.after(ms=1000, func=lambda: self.root.close())
67-
with self.assertRaises(TypeError):
68-
Dialog.select_directory(initial_dir=1)
69-
with self.assertRaises(TypeError):
70-
Dialog.select_directory(title=lambda: None)
71-
7247
def test_color_chooser_no_params(self):
7348
self.root.after(ms=1000, func=lambda: self.root.close())
7449
Dialog.choose_color()
@@ -77,13 +52,6 @@ def test_color_chooser_good_params(self):
7752
self.root.after(ms=1000, func=lambda: self.root.close())
7853
Dialog.choose_color(initial_color="101010", as_rgb=True)
7954

80-
def test_color_chooser_bad_params(self):
81-
self.root.after(ms=1000, func=lambda: self.root.close())
82-
with self.assertRaises(TypeError):
83-
Dialog.choose_color(initial_color=1234)
84-
with self.assertRaises(TypeError):
85-
Dialog.choose_color(as_rgb=42)
86-
8755
def test_info_box_no_params(self):
8856
self.root.after(ms=1000, func=lambda: self.root.close())
8957
with self.assertRaises(TypeError):
@@ -93,17 +61,6 @@ def test_info_box_good_params(self):
9361
self.root.after(ms=1000, func=lambda: self.root.close())
9462
Dialog.show_info(parent=self.root, title="Title", message="Message", detail="Details")
9563

96-
def test_info_box_bad_params(self):
97-
self.root.after(ms=1000, func=lambda: self.root.close())
98-
with self.assertRaises(TypeError):
99-
Dialog.show_info(parent=321123, title="", message="")
100-
with self.assertRaises(TypeError):
101-
Dialog.show_info(self.root, title=False, message="")
102-
with self.assertRaises(TypeError):
103-
Dialog.show_info(self.root, title="", message=())
104-
with self.assertRaises(TypeError):
105-
Dialog.show_info(self.root, title="", message="", detail=[])
106-
10764
def test_warning_box_no_params(self):
10865
self.root.after(ms=1000, func=lambda: self.root.close())
10966
with self.assertRaises(TypeError):
@@ -113,17 +70,6 @@ def test_warning_box_good_params(self):
11370
self.root.after(ms=1000, func=lambda: self.root.close())
11471
Dialog.show_warning(parent=self.root, title="Title", message="Message", detail="Details")
11572

116-
def test_warning_box_bad_params(self):
117-
self.root.after(ms=1000, func=lambda: self.root.close())
118-
with self.assertRaises(TypeError):
119-
Dialog.show_warning(parent="asdf", title="", message="")
120-
with self.assertRaises(TypeError):
121-
Dialog.show_warning(self.root, title=1, message="")
122-
with self.assertRaises(TypeError):
123-
Dialog.show_warning(self.root, title="", message=lambda: None)
124-
with self.assertRaises(TypeError):
125-
Dialog.show_warning(self.root, title="", message="", detail=[])
126-
12773
def test_error_box_no_params(self):
12874
self.root.after(ms=1000, func=lambda: self.root.close())
12975
with self.assertRaises(TypeError):
@@ -138,17 +84,6 @@ def test_error_box_good_params(self):
13884
except tk.TclError:
13985
pass
14086

141-
def test_error_box_bad_params(self):
142-
self.root.after(ms=1000, func=lambda: self.root.close())
143-
with self.assertRaises(TypeError):
144-
Dialog.show_error(parent="asdf", title="", message="")
145-
with self.assertRaises(TypeError):
146-
Dialog.show_error(self.root, title=1, message="")
147-
with self.assertRaises(TypeError):
148-
Dialog.show_error(self.root, title="", message=lambda: None)
149-
with self.assertRaises(TypeError):
150-
Dialog.show_error(self.root, title="", message="", detail=[])
151-
15287
def test_ok_cancel_box_no_params(self):
15388
self.root.after(ms=1000, func=lambda: self.root.close())
15489
with self.assertRaises(TypeError):
@@ -158,17 +93,6 @@ def test_ok_cancel_box_good_params(self):
15893
self.root.after(ms=1000, func=lambda: self.root.close())
15994
Dialog.ask_ok_or_cancel(parent=self.root, title="Title", message="Message", detail="Details")
16095

161-
def test_ok_cancel_box_bad_params(self):
162-
self.root.after(ms=1000, func=lambda: self.root.close())
163-
with self.assertRaises(TypeError):
164-
Dialog.ask_ok_or_cancel(parent="asdf", title="", message="")
165-
with self.assertRaises(TypeError):
166-
Dialog.ask_ok_or_cancel(self.root, title=1, message="")
167-
with self.assertRaises(TypeError):
168-
Dialog.ask_ok_or_cancel(self.root, title="", message=lambda: None)
169-
with self.assertRaises(TypeError):
170-
Dialog.ask_ok_or_cancel(self.root, title="", message="", detail=[])
171-
17296
def test_yes_no_box_no_params(self):
17397
self.root.after(ms=1000, func=lambda: self.root.close())
17498
with self.assertRaises(TypeError):
@@ -178,17 +102,6 @@ def test_yes_no_box_good_params(self):
178102
self.root.after(ms=1000, func=lambda: self.root.close())
179103
Dialog.ask_yes_or_no(parent=self.root, title="Title", message="Message", detail="Details")
180104

181-
def test_yes_no_box_bad_params(self):
182-
self.root.after(ms=1000, func=lambda: self.root.close())
183-
with self.assertRaises(TypeError):
184-
Dialog.ask_yes_or_no(parent="asdf", title="", message="")
185-
with self.assertRaises(TypeError):
186-
Dialog.ask_yes_or_no(self.root, title=1, message="")
187-
with self.assertRaises(TypeError):
188-
Dialog.ask_yes_or_no(self.root, title="", message=lambda: None)
189-
with self.assertRaises(TypeError):
190-
Dialog.ask_yes_or_no(self.root, title="", message="", detail=[])
191-
192105
def test_yes_no_cancel_box_no_params(self):
193106
self.root.after(ms=1000, func=lambda: self.root.close())
194107
with self.assertRaises(TypeError):
@@ -198,18 +111,6 @@ def test_yes_no_cancel_box_good_params(self):
198111
self.root.after(ms=1000, func=lambda: self.root.close())
199112
Dialog.ask_yes_or_no_or_cancel(parent=self.root, title="Title", message="Message", detail="Details")
200113

201-
def test_yes_no_cancel_box_bad_params(self):
202-
self.root.after(ms=1000, func=lambda: self.root.close())
203-
with self.assertRaises(TypeError):
204-
Dialog.ask_yes_or_no_or_cancel(parent="asdf", title="", message="")
205-
with self.assertRaises(TypeError):
206-
Dialog.ask_yes_or_no_or_cancel(self.root, title=1, message="")
207-
with self.assertRaises(TypeError):
208-
Dialog.ask_yes_or_no_or_cancel(self.root, title="", message=lambda: None)
209-
with self.assertRaises(TypeError):
210-
Dialog.ask_yes_or_no_or_cancel(self.root, title="", message="",
211-
detail=[])
212-
213114
def test_retry_cancel_box_no_params(self):
214115
self.root.after(ms=1000, func=lambda: self.root.close())
215116
with self.assertRaises(TypeError):
@@ -219,22 +120,9 @@ def test_retry_cancel_box_good_params(self):
219120
self.root.after(ms=1000, func=lambda: self.root.close())
220121
Dialog.ask_retry_cancel(parent=self.root, title="Title", message="Message", detail="Details")
221122

222-
def test_retry_cancel_box_bad_params(self):
223-
self.root.after(ms=1000, func=lambda: self.root.close())
224-
with self.assertRaises(TypeError):
225-
Dialog.ask_retry_cancel(parent="asdf", message="", title="")
226-
with self.assertRaises(TypeError):
227-
Dialog.ask_retry_cancel(self.root, title=1, message="")
228-
with self.assertRaises(TypeError):
229-
Dialog.ask_retry_cancel(self.root, title="", message=lambda: None)
230-
with self.assertRaises(TypeError):
231-
Dialog.ask_retry_cancel(self.root, title="", message="", detail=[])
232-
233123
def test_custom_dialog(self):
234124
self.root.lift()
235125
self.root.after(ms=1000, func=lambda: self.root.close())
236-
with self.assertRaises(TypeError):
237-
Dialog.CustomDialog(parent="lol")
238126
dialog = Dialog.CustomDialog(parent=self.root)
239127
dialog.title = "Title"
240128
# Must lift everything otherwise it hasn't drawn and grabbing the

0 commit comments

Comments
 (0)