Skip to content

Conversation

@UnkindPartition
Copy link
Owner

This is the current work I have for #309. Please review and test it well before merging; I don't remember (and can't test right now) if it actually worked.

@santiweight
Copy link

Thank you for this! I will try to test this out on Monday at work. If I don't respond in a couple days and you still want review, please ping :)

@VictorCMiraldo
Copy link
Collaborator

I'd love to write a test for this, but my attempts behave the same at master and on this branch. I've tried:

  • Write a testGroup that launches processes, then manually send SIGINT: I see the entire process killed and get my shell back in both branches
  • Write a testGroup with one test that sends SIGINT to $$, only that test fails on both branches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants