Make check_starting_point of test_move launch files configurable #1354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This recently came up in #1349 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1354 +/- ##
========================================
+ Coverage 3.59% 5.07% +1.48%
========================================
Files 13 33 +20
Lines 947 3430 +2483
Branches 152 421 +269
========================================
+ Hits 34 174 +140
- Misses 843 3254 +2411
+ Partials 70 2 -68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This should allow to use them in situations, where the robot is not at the preconfigured pose, but users understand the risks and want to circumvent this. Also, I updated the documentation around this.
urfeex
force-pushed
the
improve_test_launches
branch
from
2d06cde to
7bc1ddb
Compare
urmahp
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow to use them in situations, where the robot is not at the preconfigured pose, but users understand the risks and want to circumvent this.
Also, I updated the documentation around this.