-
Notifications
You must be signed in to change notification settings - Fork 301
Hardware interface for sending motion primitives to the robot via the Instruction Executor instead of trajectories #1341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…overflow error when launching
…calls (and moved some more code to the helper header)
…tware_version_major_>= 5) in transform_force_torque() since ur_driver_ is not available in the ur_state_helper.hpp
… case to fit the rest of the repo
…31415/ros2_motion_primitives_ur_driver_pkg to the Universal_Robots_ROS2_Driver
… the hardware interface can receive a new motion primitive — replaces the previous, more complex handling via execution_status
…unch.py and added if else for driver_type to load the right ros2_control.xacro file in ur.urdf.xacro
|
@mathias31415 regarding b4f4dec, please let's keep that back for a follow-up PR. |
…truction_executor_ execution is done
…::array<double, 25>, 1> → therefore changed command and state interfaces from std::vector<double> to std::array<double, 25>.
Co-authored-by: Felix Exner <feex@universal-robots.com>
…refix is passed as param to moprim forward controller
Co-authored-by: Felix Exner <feex@universal-robots.com>
|
@mathias31415 could you please fix the merge conflicts for this? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1341 +/- ##
==========================================
+ Coverage 3.59% 15.36% +11.77%
==========================================
Files 13 34 +21
Lines 947 3860 +2913
Branches 152 482 +330
==========================================
+ Hits 34 593 +559
- Misses 843 3250 +2407
+ Partials 70 17 -53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. A few nitpicks left, but I'll take them to a follow-up.
Just as a note for now:
- Remove logging from perform_switch
- Add moprim interface to compatibility matrix
- Fix end-of-file in controller-yaml
This PR extends the
ur_robot_driverpackage with a hardware interface for sending motion primitives to the robot via the Instruction Executor instead of traditional trajectory execution.To reuse the state interface functionalities of the original hardware interface in the new
motion_primitive_ur_driver, these functionalities have been refactored into a shared helper file:stateinterface_helper.hpp.The implementation uses the
motion_primitives_forward_controller, which is planned to be integrated into theros2_controllersrepository. (ros-controls/ros2_controllers#1636)Motion primitives are received by the controller using the
MotionPrimitive.msgfrom theindustrial_robot_motion_interfacespackage. A modified version of this message is used here, which includes additional helper types:STOP_MOTION: Interrupts current robot motion and clears the motion queue.MOTION_SEQUENCE_STARTandMOTION_SEQUENCE_END: Define a sequence block—primitives between these markers are grouped and executed as a single, blended motion sequence. This enables smooth transitions between individual primitives, unlike executing them one by one.This implementation also depends on a pending Pull Request in the
Universal_Robots_Client_Library. This PR extends the Instruction Executor with support formoveccommands, which is required for executing circular Cartesian motions within this driver.I'd appreciate any feedback or suggestions – thanks in advance!