Skip to content

Use colored log output and timestamps in default log handler #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

urfeex
Copy link
Member

@urfeex urfeex commented Feb 11, 2025

I've had this lying around when implementing things. Maybe that would be useful to have it in the general library.

Without this change:
image

With this change:
image

@urfeex urfeex requested a review from a team February 11, 2025 12:38
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.40%. Comparing base (97ad825) to head (f1cd72d).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #267      +/-   ##
==========================================
- Coverage   73.41%   73.40%   -0.02%     
==========================================
  Files          80       80              
  Lines        3182     3177       -5     
  Branches      398      398              
==========================================
- Hits         2336     2332       -4     
+ Misses        628      626       -2     
- Partials      218      219       +1     
Flag Coverage Δ
ur20-latest 72.05% <100.00%> (-0.02%) ⬇️
ur5-3.14.3 72.91% <100.00%> (-0.05%) ⬇️
ur5e-5.9.4 72.73% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@urrsk urrsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the colours, it improves the readability. And I love the timestamp!

@urfeex urfeex merged commit 55ec716 into UniversalRobots:master Feb 18, 2025
20 of 23 checks passed
@urfeex urfeex deleted the colored_log_handler branch February 18, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants