bug(interop): no app_id on wayland

[deathtrip]

Describe the bug

When running UAD-ng, or the previous gen UAD for that matter, the app_id value on wayland is empty.
This is a problem when setting window rules on tiling window managers, and for programs thet rename workspaces based on their app_id.

Expected behavior

There should be a app_id value.

You have a solution?

No response

Operating System

Linux

Window Manager

sway

Desktop Environment

No response

Provide logs

I don't think it applies to this issue.

Acknowledgements

• This issue is not a duplicate of an existing bug report.
• I have chosen an appropriate title.
• All requested information has been provided properly.

[Rudxain]

I guess this is more like a feature request?

Iced supports this. This might get resolved by #551 #603

[deathtrip]

It's not really a feature, more like a standard, and it's a rarity for an application to not provide it.

[AnonymousWP]

Could you help us by submitting a PR?

[deathtrip]

Unfortunately not, as i am not familiar with the UAD codebase nor rust in general.

[Rudxain]

I was reading the docs, and it turns out (according to rust-analyzer) we aren't even touching using iced::settings 💀

I'll open a PR for that, but I still have no idea where to pass the struct

[Rudxain]

Wait, we are using iced::Settings (alias of iced::settings::Settings), but not iced::settings directly (notice the casing of "s")

[Rudxain]

Found it!:

universal-android-debloater-next-generation/src/gui/mod.rs

Lines 390 to 403 in 4f9332c

	Self::run(Settings {
	window: Window {
	size: iced::Size {
	width: 950.0,
	height: 700.0,
	},
	resizable: true,
	decorations: true,
	icon: icon::from_file_data(logo, Some(ImageFormat::Png)).ok(),
	..iced::window::Settings::default()
	},
	default_text_size: iced::Pixels(16.0),
	..Settings::default()
	})

It's an easy fix! We just have to specify the id field, because default is None (the Iced PR made me believe it was inferred from crate name, which is what Clap does)

[Rudxain]

@deathtrip Can you please test this version to see if the metadata is set?

I have Wayland, but not Sway, only Mutter

[deathtrip]

Just tested the version linked in the above post, and the app_id is still empty.

[Rudxain]

After reading more docs, I suspect this is an Iced bug, which implies this isn't something we can/should fix. Unless, it's something specific to the version main uses, in that case it could be fixed by #551