Skip to content

Made admin panel tables sortable and filterable #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 29, 2024

Conversation

sheldor1510
Copy link
Collaborator

  • Added functionality for admins to sort tables in any order (asc or desc) and filter the rows by a specific value
  • All parameters for sorting and filtering are stored as GET vars in the URL (for bookmarking specific links)
  • Make admin panel tables sortable and filterable #70

@sheldor1510 sheldor1510 requested a review from hakasapl June 16, 2023 18:05
Copy link
Collaborator

@hakasapl hakasapl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally got a chance to test this. This works well as is, but I have a some front-end changes:

  1. Change the cursor to a pointer when hovering the sort or filter buttons using css: cursor: pointer
  2. The filter textboxes don't fully align with the table headers. I would suggest using javascript to determine the current length of the column in question, then dynamically set the width and position of the text box depending on that. Keep in mind the column widths can change depending on the size of the browser, that's why javascript is needed.

I would also like to be able to filter by multiple fields at the same time, but that doesn't have to be in this PR.

Good stuff, thank you!

@hakasapl hakasapl self-requested a review February 16, 2024 16:35
Copy link
Collaborator

@hakasapl hakasapl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@hakasapl hakasapl merged commit dcd4409 into UnityHPC:main May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants