stored max id values in sitevars table #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hakasapl
requested changes
Jun 9, 2023
There was a problem hiding this comment.
In all three methods, could you add an additional bit of logic that checks the LDAP DB to make sure that $new_uid is not currently being used by an ldap object? You only need to check the OU that corresponds ot the method. If it is used, increment 1 to the value and check again, so this should probably be a while loop.
|
It looks like there is already a method header for UIDNumInUse, but it just returns false. You can use that header |
hakasapl
requested changes
Jun 9, 2023
| return $id; | ||
| $UnitySQL->updateSiteVar('MAX_GID', $new_gid); | ||
|
|
||
| return $new_gid; | ||
| } | ||
|
|
||
| private function UIDNumInUse($id) |
There was a problem hiding this comment.
I'd prefer if you made 2 additional methods for GIDNumInUse and PIGIDNumInUse to keep it consistent.
Co-authored-by: Hakan Saplakoglu <hakansaplakog@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sitevars(Structure:id,name,value)MAX_UID,MAX_GID,MAX_PIGID.