Skip to content

cleanup panel/account.php #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2025
Merged

cleanup panel/account.php #201

merged 2 commits into from
Apr 24, 2025

Conversation

simonLeary42
Copy link
Collaborator

@simonLeary42 simonLeary42 commented Apr 24, 2025

  • use JS instead of PHP for making the initial login shell selection
  • inject PHP variables into JS on its own string declaration line
  • use one showOrHideCustomLoginBox function for updates and initial state, rather than writing the same logic 3 times
  • use value "Custom" everywhere rather than using "custom" internally and "Custom externally"

@simonLeary42
Copy link
Collaborator Author

tested:

  • custom login box is visible only when "Custom" is selected in dropdowon
  • correct dropdown option is selected based on value in LDAP for each default shell and a custom shell
Screen.Recording.2025-04-24.at.11.07.26.AM.mov

@simonLeary42 simonLeary42 merged commit f0795fa into main Apr 24, 2025
2 of 3 checks passed
simonLeary42 added a commit that referenced this pull request Apr 30, 2025
* cleanup code

* Custom not custom
@simonLeary42 simonLeary42 deleted the cleanup-panel-account branch June 6, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant