Skip to content

Commit 8326a81

Browse files
author
Michael DeRoy
committed
Fix issue where the plugin would be enabled in minidumps and would crash
1 parent d2d623a commit 8326a81

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

UnityMixedCallstackFilter.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ private static bool TryGetDescriptionForIp(ulong ip, out string name)
181181

182182
public void OnModuleInstanceLoad(DkmModuleInstance moduleInstance, DkmWorkList workList, DkmEventDescriptorS eventDescriptor)
183183
{
184-
if (moduleInstance.Name.Contains("mono-2.0"))
184+
if (moduleInstance.Name.Contains("mono-2.0") && moduleInstance.MinidumpInfoPart == null)
185185
_enabled = true;
186186
}
187187
}

source.extension.vsixmanifest

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<PackageManifest Version="2.0.0" xmlns="http://schemas.microsoft.com/developer/vsx-schema/2011" xmlns:d="http://schemas.microsoft.com/developer/vsx-schema-design/2011">
33
<Metadata>
4-
<Identity Id="UnityMixedCallstack.mderoy.1bc395e8-c1ea-4a2d-8a37-19e7f0c302b9" Version="2.3" Language="en-US" Publisher="Jb Evain, Michael DeRoy, Jonathan Chambers" />
4+
<Identity Id="UnityMixedCallstack.mderoy.1bc395e8-c1ea-4a2d-8a37-19e7f0c302b9" Version="2.4" Language="en-US" Publisher="Jb Evain, Michael DeRoy, Jonathan Chambers" />
55
<DisplayName>Unity Mixed Callstack</DisplayName>
66
<Description xml:space="preserve">Visual Studio native debugger extension to help debug native applications using Mono. Originally developed by Jb Evain, Updated for Unity by Michael DeRoy and Jonathan Chambers</Description>
77
</Metadata>

0 commit comments

Comments
 (0)