Skip to content

Commit a01fe0b

Browse files
authored
Fix PGO jobs on official builds (dotnet#65669)
After dotnet#65603 the official build failed because we missed passing in the `isOfficialBuild` variable on the PGO jobs. * Don't sign PGO bits * Don't run upload-intermediate-artifacts-step.yml for PGO leg
1 parent 41ab200 commit a01fe0b

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

eng/pipelines/coreclr/templates/build-job.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -317,7 +317,7 @@ jobs:
317317
SecretsFilter: 'dotnetfeed-storage-access-key-1,microsoft-symbol-server-pat,symweb-symbol-server-pat'
318318

319319
# Save packages using the prepare-signed-artifacts format.
320-
- ${{ if and(eq(parameters.isOfficialBuild, true), ne(parameters.testGroup, 'clrTools')) }}:
320+
- ${{ if and(eq(parameters.isOfficialBuild, true), ne(parameters.testGroup, 'clrTools'), eq(parameters.pgoType, '')) }}:
321321
- template: /eng/pipelines/common/upload-intermediate-artifacts-step.yml
322322
parameters:
323323
name: ${{ parameters.platform }}

eng/pipelines/runtime-official.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -382,6 +382,8 @@ stages:
382382
- windows_x86
383383
- Linux_x64
384384
jobParameters:
385+
isOfficialBuild: ${{ variables.isOfficialBuild }}
386+
signBinaries: false
385387
testGroup: innerloop
386388
pgoType: 'PGO'
387389

0 commit comments

Comments
 (0)