fix an issue with adding generic param numbers

added null termination to the streaming buffer
fixed missing return statement

Author: realek

mono/metadata/class.c

@@ -602,6 +602,8 @@ mono_identifier_escape_type_append (char *bufferPtr, const char *identifier)
 			return bufferPtr;
 		}
 	}
+
+	return bufferPtr;
 }
 
 enum {
@@ -622,8 +624,8 @@ static void
 mono_type_get_name_foreach_name_chunk_recurse (MonoType *type, gboolean is_recursed, MonoTypeNameFormat format, GFunc nameChunkReport, void *userData)
 {
 	MonoClass *klass = NULL;
-	char buffer[kNameChunkBufferSize];
-	memset (buffer, 0x00, kNameChunkBufferSize);
+	char buffer[kNameChunkBufferSize + 1]; //null terminate the buffer
+	memset (buffer, 0x00, kNameChunkBufferSize + 1);
 	char *bufferPtr = buffer;
 	char *bufferIter = buffer;
 
@@ -722,7 +724,7 @@ mono_type_get_name_foreach_name_chunk_recurse (MonoType *type, gboolean is_recur
 				*bufferIter++ = '!';
 				*bufferIter++ = '!';
 			}
-			sprintf (bufferIter, type->data.generic_param->num);
+			sprintf (bufferIter, "%d", type->data.generic_param->num);
 		} else
 			nameChunkReport (mono_generic_param_info (type->data.generic_param)->name, userData);