Fix a possible crash while printing a warning

Josh Peterson · Josh Peterson · commit 0cfc4bb0b523 · 2019-03-11T08:48:17.000-04:00
The format string was incorrect in this case, which leads to this crash in Unity: https://crashes.hq.unity3d.com/crashes/5aa00d01b4db11000de20c8e?versions_range=2018.3.5..2019.2.99&date_start=&date_end=&source= Simply remove the unused `%s` format specifier here.
diff --git a/mono/metadata/threadpool-io.c b/mono/metadata/threadpool-io.c
@@ -189,7 +189,7 @@ selector_thread_wakeup_drain_pipes (void)
 			break;
 		if (received == SOCKET_ERROR) {
 			if (WSAGetLastError () != WSAEINTR && WSAGetLastError () != WSAEWOULDBLOCK)
-				g_warning ("selector_thread_wakeup_drain_pipes: recv () failed, error (%d) %s\n", WSAGetLastError ());
+				g_warning ("selector_thread_wakeup_drain_pipes: recv () failed, error (%d)\n", WSAGetLastError ());
 			break;
 		}
 #endif
@@ -714,4 +714,4 @@ mono_threadpool_io_remove_domain_jobs (MonoDomain *domain)
 	g_assert_not_reached ();
 }
 
-#endif
+#endif

Original file line number	Diff line number	Diff line change
`@@ -189,7 +189,7 @@ selector_thread_wakeup_drain_pipes (void)`
`189`	`189`	`break;`
`190`	`190`	`if (received == SOCKET_ERROR) {`
`191`	`191`	`if (WSAGetLastError () != WSAEINTR && WSAGetLastError () != WSAEWOULDBLOCK)`
`192`		`- g_warning ("selector_thread_wakeup_drain_pipes: recv () failed, error (%d) %s\n", WSAGetLastError ());`
	`192`	`+ g_warning ("selector_thread_wakeup_drain_pipes: recv () failed, error (%d)\n", WSAGetLastError ());`
`193`	`193`	`break;`
`194`	`194`	`}`
`195`	`195`	`#endif`
`@@ -714,4 +714,4 @@ mono_threadpool_io_remove_domain_jobs (MonoDomain *domain)`
`714`	`714`	`g_assert_not_reached ();`
`715`	`715`	`}`
`716`	`716`
`717`		`-#endif`
	`717`	`+#endif`