support newer versions of tensorflow (2.1+) #3830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently 2.2.0rc1 is not > 2.0.0 |
andrewcoh
reviewed
Apr 23, 2020
| @@ -61,7 +62,7 @@ def run(self): | |||
| "Pillow>=4.2.1", | |||
| "protobuf>=3.6", | |||
| "pyyaml", | |||
| "tensorflow>=1.7,<2.1", | |||
| "tensorflow>=1.7,<3.0", | |||
There was a problem hiding this comment.
I did have to add six>=1.12.0 to setup.py for tf>2.1.0
There was a problem hiding this comment.
yeah, I'm not sure what to do about this. pip should be able to figure it out; it's not really our requirement, just a transitive one.
10 tasks
* increase gail visual ppo steps * increase to 2000 * tune steps down to 750
andrewcoh
approved these changes
Apr 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Tests with tensorflow 2.1 and 2.2 release candidates look good. We need to support 2.2 in order to support python3.8 as well.
This PR raises the tensorflow version range. I originally intended to test python3.8 here too, but there were some conflicts with onnx that I'll have to try to resolve in another PR.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
tensorflow/tensorflow#33374
Types of change(s)
Checklist
Other comments