Testing gym with basic environment #3725
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
xiaomaogy
reviewed
Apr 3, 2020
| @@ -45,6 +48,8 @@ def run_standalone_build( | |||
| test_args += ["-logfile", "-"] | |||
| if output_path is not None: | |||
| test_args += ["--mlagents-build-output-path", output_path] | |||
| if scene_path is not None: | |||
| test_args += ["--mlagents-build-scene-path", scene_path] | |||
There was a problem hiding this comment.
The whole PR make sense to me. Just wondering who is parsing this --mlagents-build-scene-path arg?
There was a problem hiding this comment.
https://github.com/Unity-Technologies/ml-agents/blob/master/Project/Assets/ML-Agents/Editor/Tests/StandaloneBuildTest.cs#L11
That would be the BuildStandalonePlayerOSX method in the StandaloneBuildTest.cs file.
xiaomaogy
approved these changes
Apr 3, 2020
chriselion
approved these changes
Apr 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Types of change(s)
Checklist
[ ] Updated the changelog (if applicable)[ ] Updated the documentation (if applicable)[ ] Updated the migration guide (if applicable)Other comments