cleanup port logic in UnityEnvironment #3673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
chriselion
commented
Mar 23, 2020
| @@ -193,7 +193,7 @@ messages to the Unity environment from Python using it. | |||
| string_log = StringLogChannel() | |||
|
|
|||
| # We start the communication with the Unity Editor and pass the string_log side channel as input | |||
| env = UnityEnvironment(base_port=UnityEnvironment.DEFAULT_EDITOR_PORT, side_channels=[string_log]) | |||
| env = UnityEnvironment(side_channels=[string_log]) | |||
There was a problem hiding this comment.
Since these should now do the correct thing, I removed the explicit port (for simplicity and future-proofing) wherever I found it in the docs.
chriselion
commented
Mar 23, 2020
| @@ -8,8 +8,8 @@ def __init__(self, worker_id=0, base_port=5005): | |||
| """ | |||
| Python side of the communication. Must be used in pair with the right Unity Communicator equivalent. | |||
|
|
|||
| :int worker_id: Offset from base_port. Used for training multiple environments simultaneously. | |||
There was a problem hiding this comment.
Rearranged to match the argument order. I think I changed the wording of this wherever I saw it (git blame showed it was 3 years old).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
@awjuliani hit this a few weeks ago, and it came up in an issue today too. If no environment was specified, we would still default to port 5005, but we should be smart enough to use 5004 (the editor port) in this case.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
#3667
https://jira.unity3d.com/browse/MLA-709?
Types of change(s)
Checklist
Other comments