Skip to content

merge release 0.15.0 into master #3652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Mar 19, 2020
Merged

merge release 0.15.0 into master #3652

merged 20 commits into from
Mar 19, 2020

Conversation

vincentpierre
Copy link
Contributor

Proposed change(s)

From the release checklist

Make a new branch off the release branch. 
Merge master into this new branch and resolve the conflicts. 
Once all the conflicts have been resolved, make a pull request
to merge this new branch into master, and merge it.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

vincentpierre and others added 17 commits March 11, 2020 18:41
@vincentpierre
Bumping version on the release (#3615)
ee6736f
Update examples project to 2018.4.18f1 (#3618)
ac6bfce 
From 2018.4.14f1.  An internal package dependency was updated as
a side effect.
@vincentpierre
Remove dead components from the examples scenes (#3619) (#3624)
4745b8b
Improve warnings and exception if using unsupported combo
a13f595
add meta file
1cec320
fix unit test
69e1684
enforce onnx conversion (expect tf2 CI to fail) (#3600)
01c32ca
Update error message
9e2adc9
Merge pull request #3628 from Unity-Technologies/release-0.15.0-onnx-CI
5f01d16 
enforce onnx conversion in CI
Merge pull request #3627 from Unity-Technologies/release-0.15.0-log-n…
3ad43b3 
…o-model

[MLA-762] Better logging when no model + inference only
@vincentpierre
Updated the release branch docs (#3621)
01d5497 
* Updated the release branch docs

* Edited the README
make sure top-level timer is closed before writing
f4359bb
Remove space from Product Name for examples
40d6547 
In #2588 it was suggested that the space in the Product Name for
our example environments causes confusion when using a default build
because of the need to escape the space in the build filename.

This change removes the space from the Product Name in the project's
player settings.
Merge pull request #3631 from Unity-Technologies/release-0.15.0-fix-s…
284b207 
…tats

make sure top-level timer is closed before writing
[bug-fix] Increase 3dballhard and GAIL default steps (#3636)
5d2d523
@vincentpierre
Updating the NN models (#3632)
7507a5d 
* Updating the NN models

* Update gridworld

* [skip ci] Update BallHard

* Update hallway
@vincentpierre
Resolving the conflicts
39c3054
@vincentpierre vincentpierre self-assigned this Mar 18, 2020
chriselion
chriselion reviewed Mar 19, 2020
View reviewed changes
README.md
@@ -29,14 +29,14 @@ developer communities.
* Unity environment control from Python
* 15+ sample Unity environments
* Two deep reinforcement learning algorithms,
[Proximal Policy Optimization](https://github.com/Unity-Technologies/ml-agents/tree/latest_release/docs/Training-PPO.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep these pointing to latest_release?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? Is there a reason for it?

Copy link
Contributor

@chriselion chriselion Mar 19, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that people landing on the main page will get linked to the latest_release of the docs instead of the master docs (which are sometime incompatible)

Copy link
Contributor Author

@vincentpierre vincentpierre Mar 19, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would mean that we would need to change it everytime we do a release right? (since we do not was any latest_release tag in the release branches.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would only happen if they are on the master branch (in which case the docs should point to master). If they want the docs for the latest release, they should actually check the tag for latest_release.

I think you are pointing to another issue, which is latest_release branch should be the landing page of ml-agents.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's take the discussion offline. This is good to merge as it is.

@vincentpierre vincentpierre merged commit 4f12bde into master Mar 19, 2020
@delete-merged-branch delete-merged-branch bot deleted the develop-merge-0.15.0 branch March 19, 2020 19:20
mmattar pushed a commit that referenced this pull request Mar 20, 2020
Remove unnecessary new line added in #3652
0956b21
@mmattar mmattar mentioned this pull request Mar 20, 2020
Merged
10 tasks
mmattar pushed a commit that referenced this pull request Mar 20, 2020
Remove unnecessary new line added in #3652 (#3663)
cdcc320
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chriselion chriselion chriselion approved these changes

@harperj harperj Awaiting requested review from harperj

@ervteng ervteng Awaiting requested review from ervteng

Assignees

@vincentpierre vincentpierre

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincentpierre @chriselion