Skip to content

Move Demonstration code to sub-folder #3488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2020

Conversation

chriselion
Copy link
Contributor

@chriselion chriselion commented Feb 24, 2020

Proposed change(s)

  • Moves Demonstration-related code to a Demonstrations directory.
  • Renames DemonstrationStore to DemonstrationWriter.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added updated the changelog (if applicable)
  • I have added necessary documentation (if applicable)
  • I have updated the migration guide (if applicable)

Other comments

@chriselion chriselion requested review from surfnerd and vincentpierre and removed request for surfnerd February 24, 2020 22:30
@chriselion chriselion merged commit b4e8ba1 into master Feb 25, 2020
@delete-merged-branch delete-merged-branch bot deleted the develop-move-rename-DemonstrationStore branch February 25, 2020 00:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants