add NaN checks to reward and observation in C# #3221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surfnerd
approved these changes
Jan 15, 2020
chriselion
commented
Jan 15, 2020
| @@ -83,6 +83,12 @@ void Clear() | |||
|
|
|||
| void AddFloatObs(float obs) | |||
| { | |||
| #if DEBUG | |||
There was a problem hiding this comment.
All of the Agent.AddVectorObs methods wind up here.
There was a problem hiding this comment.
We could add a flag to bypass the check if the source was an int, bool, or one-hot if that's worth optimizing for...
vincentpierre
approved these changes
Jan 15, 2020
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have NaN checks (and set the values to 0) on the python side. However, I think throwing sooner would help the user track down the source of the NaN.
As an example of where this would help make debugging easier: #3214