Fix "memory leak" during inference #2722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentpierre
approved these changes
Oct 11, 2019
Contributor
Make a test that runs in inference mode, and assert that the buffer is empty after stepping a few times? |
Contributor
Author
|
Tests added @chriselion |
chriselion
reviewed
Oct 11, 2019
| trainer.training_buffer = construct_fake_buffer() | ||
| trainer.training_buffer.append_update_buffer(2, batch_size=None, training_length=2) | ||
| trainer.clear_update_buffer() | ||
| for _, arr in trainer.training_buffer.update_buffer.items(): |
Contributor
There was a problem hiding this comment.
No is_empty() method on the buffer? :(
Contributor
Author
There was a problem hiding this comment.
No... maybe we should add it. Also I use this in the buffer: len(next(iter(self.update_buffer.values()))) to get its length - there probably should be a length method as well.
Contributor
There was a problem hiding this comment.
Your call - I'm OK with this as it is, but I think that would be a little nicer.
Contributor
Author
There was a problem hiding this comment.
I'll make a separate PR, unless we decide to refactor the buffer anyways
chriselion
approved these changes
Oct 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't clear the update buffer if we don't update the policy. This fixes that.
Wanted to get some thoughts on this. Also, how do we test it?