Make On Demand Decision the default (#3243)

* Added a simple Decision Requester

* Modified the prefabs

* Fixing the tests and removing fields from Agent parameters

* Migrating.md

* addressing comments

* addressing comments

Author: vincentpierre

UnitySDK/Assets/ML-Agents/Editor/AgentEditor.cs

@@ -15,36 +15,13 @@ public override void OnInspectorGUI()
             var serializedAgent = serializedObject;
             serializedAgent.Update();
 
-            var actionsPerDecision = serializedAgent.FindProperty(
-                "agentParameters.numberOfActionsBetweenDecisions");
             var maxSteps = serializedAgent.FindProperty(
                 "agentParameters.maxStep");
-            var isResetOnDone = serializedAgent.FindProperty(
-                "agentParameters.resetOnDone");
-            var isOdd = serializedAgent.FindProperty(
-                "agentParameters.onDemandDecision");
-
-
 
             EditorGUILayout.PropertyField(
                 maxSteps,
                 new GUIContent(
                     "Max Step", "The per-agent maximum number of steps."));
-            EditorGUILayout.PropertyField(
-                isOdd,
-                new GUIContent(
-                    "On Demand Decisions",
-                    "If checked, you must manually request decisions."));
-            if (!isOdd.boolValue)
-            {
-                EditorGUILayout.PropertyField(
-                    actionsPerDecision,
-                    new GUIContent(
-                        "Decision Interval",
-                        "The agent will automatically request a decision every X" +
-                        " steps and perform an action at every step."));
-                actionsPerDecision.intValue = Mathf.Max(1, actionsPerDecision.intValue);
-            }
 
             serializedAgent.ApplyModifiedProperties();
 

UnitySDK/Assets/ML-Agents/Editor/Tests/MLAgentsEditModeTest.cs

@@ -266,11 +266,10 @@ public void TestAgent()
 
             agent1.agentParameters = new AgentParameters();
             agent2.agentParameters = new AgentParameters();
-            // We use event based so the agent will now try to send anything to the brain
-            agent1.agentParameters.onDemandDecision = false;
-            agent1.agentParameters.numberOfActionsBetweenDecisions = 2;
+            var decisionRequester = agent1.gameObject.AddComponent<DecisionRequester>();
+            decisionRequester.DecisionPeriod = 2;
+            decisionRequester.Awake();
             // agent1 will take an action at every step and request a decision every 2 steps
-            agent2.agentParameters.onDemandDecision = true;
             // agent2 will request decisions only when RequestDecision is called
 
             agentEnableMethod?.Invoke(agent1, new object[] { });
@@ -374,11 +373,8 @@ public void TestAgent()
 
             agent1.agentParameters = new AgentParameters();
             agent2.agentParameters = new AgentParameters();
-            // We use event based so the agent will now try to send anything to the brain
-            agent1.agentParameters.onDemandDecision = false;
-            agent1.agentParameters.numberOfActionsBetweenDecisions = 2;
-            // agent1 will take an action at every step and request a decision every 2 steps
-            agent2.agentParameters.onDemandDecision = true;
+            var decisionRequester = agent1.gameObject.AddComponent<DecisionRequester>();
+            decisionRequester.DecisionPeriod = 2;
 
             agentEnableMethod?.Invoke(agent2, new object[] { });
 
@@ -479,12 +475,11 @@ public void TestCumulativeReward()
                 "OnEnableHelper", BindingFlags.Instance | BindingFlags.NonPublic);
             agent1.agentParameters = new AgentParameters();
             agent2.agentParameters = new AgentParameters();
-            // We use event based so the agent will now try to send anything to the brain
-            agent1.agentParameters.onDemandDecision = false;
-            agent1.agentParameters.numberOfActionsBetweenDecisions = 3;
-            // agent1 will take an action at every step and request a decision every 2 steps
-            agent2.agentParameters.onDemandDecision = true;
-            // agent2 will request decisions only when RequestDecision is called
+
+            var decisionRequester = agent1.gameObject.AddComponent<DecisionRequester>();
+            decisionRequester.DecisionPeriod = 2;
+            decisionRequester.Awake();
+
             agent1.agentParameters.maxStep = 20;
 
             agentEnableMethod?.Invoke(agent2, new object[] { });