make some more classes and methods internal (#3353)

* WIP public->internal

* DemoStore back to public, internal on Timers

Author: Chris Elion

com.unity.ml-agents/Runtime/ActionMasker.cs

@@ -14,7 +14,7 @@ internal class ActionMasker
 
         readonly BrainParameters m_BrainParameters;
 
-        public ActionMasker(BrainParameters brainParameters)
+        internal ActionMasker(BrainParameters brainParameters)
         {
             m_BrainParameters = brainParameters;
         }

com.unity.ml-agents/Runtime/ICommunicator.cs

@@ -6,7 +6,7 @@
 
 namespace MLAgents
 {
-    public struct CommunicatorInitParameters
+    internal struct CommunicatorInitParameters
     {
         /// <summary>
         /// Port to listen for connections on.
@@ -21,14 +21,14 @@ public struct CommunicatorInitParameters
         /// </summary>
         public string version;
     }
-    public struct UnityRLInitParameters
+    internal struct UnityRLInitParameters
     {
         /// <summary>
         /// An RNG seed sent from the python process to Unity.
         /// </summary>
         public int seed;
     }
-    public struct UnityRLInputParameters
+    internal struct UnityRLInputParameters
     {
         /// <summary>
         /// Boolean sent back from python to indicate whether or not training is happening.
@@ -39,19 +39,19 @@ public struct UnityRLInputParameters
     /// <summary>
     /// Delegate for handling quite events sent back from the communicator.
     /// </summary>
-    public delegate void QuitCommandHandler();
+    internal delegate void QuitCommandHandler();
 
     /// <summary>
     /// Delegate for handling reset parameter updates sent from the communicator.
     /// </summary>
     /// <param name="resetParams"></param>
-    public delegate void ResetCommandHandler();
+    internal delegate void ResetCommandHandler();
 
     /// <summary>
     /// Delegate to handle UnityRLInputParameters updates from the communicator.
     /// </summary>
     /// <param name="inputParams"></param>
-    public delegate void RLInputReceivedHandler(UnityRLInputParameters inputParams);
+    internal delegate void RLInputReceivedHandler(UnityRLInputParameters inputParams);
 
     /**
     This is the interface of the Communicators.

com.unity.ml-agents/Runtime/Policy/RemotePolicy.cs

@@ -15,7 +15,7 @@ internal class RemotePolicy : IPolicy
         int m_AgentId;
         string m_FullyQualifiedBehaviorName;
 
-        protected ICommunicator m_Communicator;
+        internal ICommunicator m_Communicator;
 
         /// <inheritdoc />
         public RemotePolicy(

com.unity.ml-agents/Runtime/Sensor/Observation.cs

@@ -3,7 +3,7 @@
 
 namespace MLAgents.Sensor
 {
-    public struct Observation
+    internal struct Observation
     {
         /// <summary>
         /// The compressed sensor data. Assumed to be non-null if CompressionType != CompressionType.None

com.unity.ml-agents/Runtime/Sensor/SensorShapeValidator.cs

@@ -3,7 +3,7 @@
 
 namespace MLAgents.Sensor
 {
-    public class SensorShapeValidator
+    internal class SensorShapeValidator
     {
         private List<int[]> m_SensorShapes;
 

com.unity.ml-agents/Runtime/Sensor/StackingSensor.cs

@@ -7,7 +7,7 @@ namespace MLAgents.Sensor
     ///   |  t = now - 3  |  t = now -3  |  t = now - 2  |  t = now  |
     /// Internally, a circular buffer of arrays is used. The m_CurrentIndex represents the most recent observation.
     /// </summary>
-    public class StackingSensor : ISensor
+    internal class StackingSensor : ISensor
     {
         /// <summary>
         /// The wrapped sensor.

com.unity.ml-agents/Runtime/Timer.cs

@@ -11,7 +11,7 @@
 namespace MLAgents
 {
     [DataContract]
-    public class TimerNode
+    internal class TimerNode
     {
         static string s_Separator = ".";
         static double s_TicksToSeconds = 1e-7; // 100 ns per tick
@@ -227,7 +227,7 @@ public string DebugGetTimerString(string parentName = "", int level = 0)
     /// Tracks the most recent value of a metric. This is analogous to gauges in statsd.
     /// </summary>
     [DataContract]
-    public class GaugeNode
+    internal class GaugeNode
     {
         const float k_SmoothingFactor = .25f; // weight for exponential moving average.
 
@@ -316,7 +316,7 @@ public static TimerStack Instance
             get { return k_Instance; }
         }
 
-        public TimerNode RootNode
+        internal TimerNode RootNode
         {
             get { return m_RootNode; }
         }
@@ -389,7 +389,7 @@ public void Dispose()
         /// Potentially slow so call sparingly.
         /// </summary>
         /// <returns></returns>
-        public string DebugGetTimerString()
+        internal string DebugGetTimerString()
         {
             return m_RootNode.DebugGetTimerString();
         }