Fix improper field access of HTTPError exception

Author: sini

.github/workflows/pre-commit.yml

@@ -12,13 +12,13 @@ jobs:
     - uses: actions/checkout@v2
     - uses: actions/setup-python@v2
       with:
-        python-version: 3.7.x
+        python-version: 3.9.x
     - uses: actions/setup-ruby@v1
       with:
         ruby-version: '2.6'
     - uses: actions/setup-dotnet@v1
       with:
-        dotnet-version: '3.1.x'
+        dotnet-version: '5.0.x'
     - uses: pre-commit/action@v2.0.0
 
   markdown-link-check:

.pre-commit-config.yaml

@@ -1,3 +1,4 @@
+minimum_pre_commit_version: 2.14.1
 repos:
 -   repo: https://github.com/python/black
     rev: 19.3b0
@@ -20,14 +21,14 @@ repos:
     -   id: mypy
         name: mypy-ml-agents-envs
         files: "ml-agents-envs/.*"
-        # Exclude protobuf files and don't follow them when imported
-        exclude: >
-            (?x)^(
-                .*_pb2.py|
-                .*_pb2.pyi|
-                .*_pb2_grpc.py
-            )$
-        args: [--ignore-missing-imports, --disallow-incomplete-defs]
+        args: 
+        - --ignore-missing-imports
+        - --disallow-incomplete-defs
+        - --disable-error-code=override
+        - --disable-error-code=attr-defined # TODO: Move annotation into files
+        - --disable-error-code=valid-type # https://mypy.readthedocs.io/en/stable/common_issues.html#variables-vs-type-aliases
+        - --exclude="ml-agents-envs/mlagents_envs/communicator_objects/*_pb2.py"
+        - --show-error-codes
         additional_dependencies: [types-PyYAML, types-setuptools, types-protobuf, types-attrs]
     -   id: mypy
         name: mypy-gym-unity
@@ -91,11 +92,11 @@ repos:
     types: [markdown]
     exclude: ".*localized.*"
 
-- repo: https://github.com/dotnet/format
-  rev: "7e343070a0355c86f72bdee226b5e19ffcbac931"  # TODO - update to a tagged version when one that includes the hook is ready.
-  hooks:
-  - id: dotnet-format
-    args: [--folder, --include]
+# - repo: https://github.com/dotnet/format
+#   rev: v5.1.225507
+#   hooks:
+#   - id: dotnet-format
+#     args: [--folder, --include]
 
 # "Local" hooks, see https://pre-commit.com/#repository-local-hooks
 -   repo: local

ml-agents-envs/mlagents_envs/registry/binary_utils.py

@@ -137,7 +137,7 @@ def download_and_extract_zip(url: str, name: str) -> None:
     try:
         request = urllib.request.urlopen(url, timeout=30)
     except urllib.error.HTTPError as e:  # type: ignore
-        e.msg += " " + url
+        logger.warning(f"Failed to fetch resource at URL: {url}, reason: {e.reason}")
         raise
     zip_size = int(request.headers["content-length"])
     zip_file_path = os.path.join(zip_dir, str(uuid.uuid4()) + ".zip")
@@ -193,7 +193,9 @@ def load_remote_manifest(url: str) -> Dict[str, Any]:
     try:
         request = urllib.request.urlopen(url, timeout=30)
     except urllib.error.HTTPError as e:  # type: ignore
-        e.msg += " " + url
+        logger.warning(
+            f"Failed to fetch manifest resource at URL: {url}, reason: {e.reason}"
+        )
         raise
     manifest_path = os.path.join(tmp_dir, str(uuid.uuid4()) + ".yaml")
     with open(manifest_path, "wb") as manifest: