UTP: Add proper support for channels #986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The UTPTransport.Send method would throw a NullReferenceException exception when passed default(ArraySegment<byte>) as the message data. Now it simply sends an empty message to its remote host (not a terribly useful feature, but better than an exception).
The fragmentation pipeline was set up to handle messages up to 6KB in length, but the receive buffer was only 1KB long. Messages longer than that were just ignored (although an error message was logged).
The transport now selects an appropriate pipeline according to the delivery level of the channel, rather than send everything on the default unreliable pipeline.
cdmazom
approved these changes
Jul 27, 2021
andrews-unity
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And some minor bugfixes related to fragmentation.
To support channels, three new pipelines are created when setting up the UTP driver. When sending a message, the MLAPI
NetworkDeliveryassociated with the channel is determined and from that, we select the appropriate pipeline to send the message through.This PR also includes some tests for channels. Note that aside from fragmentation, the actual behaviour of the different channels (e.g. reliability, sequencing) is not tested. It is assumed that whatever pipeline we are sending traffic on is already well-tested in UTP itself. The reason we're testing fragmentation is that it's easy to do, but also because
UTPTransportnow exposes aMaximumMessageLengthconstant and we want to ensure messages of that specific size are handled correctly.