Skip to content

feat: Add name property for network variables #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 9, 2021
Merged

feat: Add name property for network variables #891

merged 11 commits into from
Jun 9, 2021

Conversation

bendoyon
Copy link
Contributor

@bendoyon bendoyon commented Jun 7, 2021

No description provided.

@bendoyon
Copy link
Contributor Author

bendoyon commented Jun 7, 2021

We'll need this for profiling. We've decided to submit "core" changes as separate PRs targeting develop.

Figured it was the easier/lowest cost way of doing this.

@jeffreyrainy
Copy link
Contributor

jeffreyrainy commented Jun 7, 2021 •
edited
Loading

We'll need this for profiling.

Can I see where/how this would be used ? Since NetworkVariables will go in snapshot, I have difficulty wrapping my head around how profiler will be able to get information on usage per NetworkVariable.

@becksebenius-unity
Copy link
Contributor

We'll need this for profiling.

Can I see where/how this would be used ? Since NetworkVariables will go in snapshot, I have difficulty wrapping my head around how profiler will be able to get information on usage per NetworkVariable.

I don't think I broadcast this decision adequately so apologies Jeff - right now we're going to get network variable updates in their current form reporting to the profiler, even though it will be reworked. It's a small amount of work and will do a much better job of showcasing the target user experience than anything else. We expect that significant changes will need to be made and we'll work with you on that as the snapshot system develops.

@bendoyon bendoyon changed the title Add name property for network variables feat: Add name property for network variables Jun 8, 2021
0xFA11
0xFA11 reviewed Jun 8, 2021
View reviewed changes
0xFA11
0xFA11 approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@0xFA11 0xFA11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's time to park my 🚀 here :)

@bendoyon bendoyon enabled auto-merge (squash) June 9, 2021 17:02
@bendoyon bendoyon merged commit 28e1d85 into develop Jun 9, 2021
@bendoyon bendoyon deleted the feature/network-variable-names branch June 9, 2021 18:43
mattwalsh-unity
mattwalsh-unity reviewed Jun 9, 2021
View reviewed changes
com.unity.multiplayer.mlapi/Runtime/NetworkVariable/Collections/NetworkList.cs
@@ -72,6 +72,8 @@ public NetworkList(IList<T> value)
m_List = value;
}

public string Name { get; internal set; }
Copy link
Contributor

@mattwalsh-unity mattwalsh-unity Jun 9, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, forgot the <summary> comment here

SamuelBellomo added a commit that referenced this pull request Jun 22, 2021
@SamuelBellomo
Merge branch 'develop' into feature/adding-tests-for-network-transform
7a73d66 
* develop: (21 commits)
  feat: NetworkObject Parenting (#855)
  refactor: move RpcMethodId serialization from ILPP to Core (#910)
  fix: NetworkPrefabs container's elements invalidated in the NetworkManager after relaunching Unity Project (#905)
  feat!: OnNetworkSpawn / OnNetworkDespawn (#865)
  feat: Add missing XMLdoc comment (#897)
  refactor: upgrade ILPP backend, drop 2019.4 support, rename types/fields (#895)
  fix: do not access/render runtime info if not playing in the editor (#898)
  feat: Add name property for network variables (#891)
  chore: delete PhilTestResults.xml (#894)
  feat: MultiInstanceHelpers to use fixed FrameRate by default (#893)
  test: General MultiInstanceHelper improvements (#885)
  refactor: isKinematic set to true for rigid bodies of non-authorized instances (#886)
  docs: adding more info to help debug on network transform error message (#892)
  feat: Add RPC Name Lookup Table Provided by NetworkBehaviourILPP (#875)
  fix: remove OnClientConnectedCallback registration from StatsDisplay (#882)
  feat: Add profiling decorator pattern (#878)
  refactor: Removing dead code for NETWORK_VARIABLE_UPDATE (#880)
  fix: update package version to 0.2.0 because of unity minversion change (#881)
  docs: Fix typo in changelog version title
  docs: Hotfix Changelog for 0.1.1 and manual update (#873)
  ...

# Conflicts:
#	com.unity.multiplayer.mlapi/Runtime/Core/NetworkBehaviour.cs
#	com.unity.multiplayer.mlapi/Runtime/Core/NetworkManager.cs
#	com.unity.multiplayer.mlapi/Tests/Runtime/BaseMultiInstanceTest.cs
#	com.unity.multiplayer.mlapi/Tests/Runtime/BaseMultiInstanceTest.cs.meta
SamuelBellomo added a commit that referenced this pull request Jun 22, 2021
@SamuelBellomo
Merge branch 'develop' into test/multiprocess-testing
e1e0f70 
* develop: (67 commits)
  feat: NetworkObject Parenting (#855)
  refactor: move RpcMethodId serialization from ILPP to Core (#910)
  fix: NetworkPrefabs container's elements invalidated in the NetworkManager after relaunching Unity Project (#905)
  feat!: OnNetworkSpawn / OnNetworkDespawn (#865)
  feat: Add missing XMLdoc comment (#897)
  refactor: upgrade ILPP backend, drop 2019.4 support, rename types/fields (#895)
  fix: do not access/render runtime info if not playing in the editor (#898)
  feat: Add name property for network variables (#891)
  chore: delete PhilTestResults.xml (#894)
  feat: MultiInstanceHelpers to use fixed FrameRate by default (#893)
  test: General MultiInstanceHelper improvements (#885)
  refactor: isKinematic set to true for rigid bodies of non-authorized instances (#886)
  docs: adding more info to help debug on network transform error message (#892)
  feat: Add RPC Name Lookup Table Provided by NetworkBehaviourILPP (#875)
  fix: remove OnClientConnectedCallback registration from StatsDisplay (#882)
  feat: Add profiling decorator pattern (#878)
  refactor: Removing dead code for NETWORK_VARIABLE_UPDATE (#880)
  fix: update package version to 0.2.0 because of unity minversion change (#881)
  docs: Fix typo in changelog version title
  docs: Hotfix Changelog for 0.1.1 and manual update (#873)
  ...

# Conflicts:
#	com.unity.multiplayer.mlapi/Tests/Runtime/com.unity.multiplayer.mlapi.runtimetests.asmdef
#	testproject/ProjectSettings/EditorBuildSettings.asset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattwalsh-unity mattwalsh-unity mattwalsh-unity left review comments

@0xFA11 0xFA11 0xFA11 approved these changes

@becksebenius-unity becksebenius-unity becksebenius-unity approved these changes

@jeffreyrainy jeffreyrainy Awaiting requested review from jeffreyrainy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bendoyon @jeffreyrainy @becksebenius-unity @0xFA11 @mattwalsh-unity