feat!: OnNetworkSpawn / OnNetworkDespawn #865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukeStampfli
commented
May 28, 2021
| { | ||
| for (int i = 0; i < ChildNetworkBehaviours.Count; i++) | ||
| { | ||
| //We check if we are it's NetworkObject owner incase a NetworkObject exists as a child of our NetworkObject | ||
| if (!ChildNetworkBehaviours[i].NetworkStartInvoked) |
There was a problem hiding this comment.
All these checks did not do anything. They were always set to false before this function was run. The conclusion seems to be that this is legacy code which is not needed.
LukeStampfli
commented
May 28, 2021
| @@ -599,21 +597,21 @@ internal void ClientCollectSoftSyncSceneObjectSweep(NetworkObject[] networkObjec | |||
| } | |||
| } | |||
|
|
|||
| internal void OnDestroyObject(ulong networkId, bool destroyGameObject) | |||
| internal void OnDespawnObject(ulong networkId, bool destroyGameObject) | |||
There was a problem hiding this comment.
Renaming this because this is really not OnDestroy but just OnDespawn.
LukeStampfli
commented
May 28, 2021
| /// </summary> | ||
| /// <param name="stream">The stream containing the spawn payload</param> | ||
| public virtual void NetworkStart(Stream stream) | ||
| public virtual void OnNetworkSpawn(Stream stream) |
There was a problem hiding this comment.
This stream overload is something we probably want to remove but will be a separate RFC/ PR
TwoTenPvP
approved these changes
May 29, 2021
Cosmin-B
approved these changes
Jun 1, 2021
LukeStampfli
commented
Jun 8, 2021
| { | ||
| InitializeVariables(); | ||
| } | ||
|
|
||
| internal void InternalOnNetworkDespawn() |
There was a problem hiding this comment.
The plan is to have this empty function filled before pre-release as we will most likely have events to unsubscribe here. That's why I pre-emptively added this function for completeness.
0xFA11
reviewed
Jun 8, 2021
0xFA11
reviewed
Jun 8, 2021
com.unity.multiplayer.mlapi/Tests/Runtime/NetworkObject/NetworkObjectOnSpawnTests.cs
Outdated
Show resolved
Hide resolved
0xFA11
reviewed
Jun 8, 2021
com.unity.multiplayer.mlapi/Tests/Runtime/NetworkObject/NetworkObjectOnSpawnTests.cs
Outdated
Show resolved
Hide resolved
0xFA11
reviewed
Jun 8, 2021
com.unity.multiplayer.mlapi/Tests/Runtime/NetworkObject/NetworkObjectOnSpawnTests.cs
Outdated
Show resolved
Hide resolved
0xFA11
reviewed
Jun 8, 2021
com.unity.multiplayer.mlapi/Tests/Runtime/NetworkObject/NetworkObjectOnSpawnTests.cs
Outdated
Show resolved
Hide resolved
0xFA11
reviewed
Jun 8, 2021
com.unity.multiplayer.mlapi/Tests/Runtime/NetworkObject/NetworkObjectOnSpawnTests.cs
Outdated
Show resolved
Hide resolved
SamuelBellomo
added a commit
that referenced
this pull request
Jun 22, 2021
* develop: (21 commits) feat: NetworkObject Parenting (#855) refactor: move RpcMethodId serialization from ILPP to Core (#910) fix: NetworkPrefabs container's elements invalidated in the NetworkManager after relaunching Unity Project (#905) feat!: OnNetworkSpawn / OnNetworkDespawn (#865) feat: Add missing XMLdoc comment (#897) refactor: upgrade ILPP backend, drop 2019.4 support, rename types/fields (#895) fix: do not access/render runtime info if not playing in the editor (#898) feat: Add name property for network variables (#891) chore: delete PhilTestResults.xml (#894) feat: MultiInstanceHelpers to use fixed FrameRate by default (#893) test: General MultiInstanceHelper improvements (#885) refactor: isKinematic set to true for rigid bodies of non-authorized instances (#886) docs: adding more info to help debug on network transform error message (#892) feat: Add RPC Name Lookup Table Provided by NetworkBehaviourILPP (#875) fix: remove OnClientConnectedCallback registration from StatsDisplay (#882) feat: Add profiling decorator pattern (#878) refactor: Removing dead code for NETWORK_VARIABLE_UPDATE (#880) fix: update package version to 0.2.0 because of unity minversion change (#881) docs: Fix typo in changelog version title docs: Hotfix Changelog for 0.1.1 and manual update (#873) ... # Conflicts: # com.unity.multiplayer.mlapi/Runtime/Core/NetworkBehaviour.cs # com.unity.multiplayer.mlapi/Runtime/Core/NetworkManager.cs # com.unity.multiplayer.mlapi/Tests/Runtime/BaseMultiInstanceTest.cs # com.unity.multiplayer.mlapi/Tests/Runtime/BaseMultiInstanceTest.cs.meta
SamuelBellomo
added a commit
that referenced
this pull request
Jun 22, 2021
* develop: (67 commits) feat: NetworkObject Parenting (#855) refactor: move RpcMethodId serialization from ILPP to Core (#910) fix: NetworkPrefabs container's elements invalidated in the NetworkManager after relaunching Unity Project (#905) feat!: OnNetworkSpawn / OnNetworkDespawn (#865) feat: Add missing XMLdoc comment (#897) refactor: upgrade ILPP backend, drop 2019.4 support, rename types/fields (#895) fix: do not access/render runtime info if not playing in the editor (#898) feat: Add name property for network variables (#891) chore: delete PhilTestResults.xml (#894) feat: MultiInstanceHelpers to use fixed FrameRate by default (#893) test: General MultiInstanceHelper improvements (#885) refactor: isKinematic set to true for rigid bodies of non-authorized instances (#886) docs: adding more info to help debug on network transform error message (#892) feat: Add RPC Name Lookup Table Provided by NetworkBehaviourILPP (#875) fix: remove OnClientConnectedCallback registration from StatsDisplay (#882) feat: Add profiling decorator pattern (#878) refactor: Removing dead code for NETWORK_VARIABLE_UPDATE (#880) fix: update package version to 0.2.0 because of unity minversion change (#881) docs: Fix typo in changelog version title docs: Hotfix Changelog for 0.1.1 and manual update (#873) ... # Conflicts: # com.unity.multiplayer.mlapi/Tests/Runtime/com.unity.multiplayer.mlapi.runtimetests.asmdef # testproject/ProjectSettings/EditorBuildSettings.asset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements RFC#16: NetworkSpawn (tracked by #864)
BREAKING CHANGE:
NetworkStartis now calledOnNetworkSpawn.Test coverage does not include scene objects because I wasn't able to get that to run with the multiinstancehelper but scene objects work on my machine ¯\(ツ)/¯.